[FEATURE] Tangent vertex attribute about tmf HOT 8 CLOSED

fee157a adds support for reading tangents from disk. After tangent triangle segment will be added, this feature will be complete.

from tmf.

Which API representations for tangents would be easier to work with? One where w is represented as a bool denoting handedness or as a float with value of either -1 or 1? The representation on disk will be the same, and any performance difference negligible. I don't know the use cases for tangents look like exactly, so it is hard for me to envision which would be more ergonomic to use.

from tmf.

170bf31 adds support for setting/getting tangent arrays on a mesh and saving them to disk (reading is partially implemented). Current API representation of Tangent is tuple ((float, float, float), float). I am still looking for feedback on this API representation of tangents.

from tmf.

ac53b94 adds support for saving and loading tangent triangle index arrays. This feature is complete, and I am just waiting for more input on the current API.

from tmf.

I noticed there is no way to read the value of HandenesType (also, I think it should be spelled Handedness). Maybe make the field pub?

from tmf.

I've done the following on the fork I use

impl From<FloatType> for HandenesType {
    fn from(value: FloatType) -> Self {
        HandenesType(value)
    }
}
impl From<HandenesType> for FloatType {
    fn from(value: HandenesType) -> Self {
        value.0
    }
}

from tmf.

HanenessType being a struct was an oversight on my part (something temporary that I forgot to remove). HanenessType was supposed to be entirely internal (just a normal float to the consumer of the API), as a way to make functions signatures more clear. Now it is just an alias for FloatType, which is an alias for either f32 or f64, depending on feature flags set.

from tmf.

Since there are no more comments, I assume the current API is OK.

from tmf.