Code Monkey home page Code Monkey logo

Comments (2)

mds1 avatar mds1 commented on July 29, 2024

I believe fail() was removed as part of the move to native cheatcode assertions from the solidity assertions. You should also be able to fail a test with revert("Reason to fail") which should be similarly convenient. cc @klkvr for more info

There also is vm.skip(bool) to conditionally skip tests if that helps

from forge-std.

CodeSandwich avatar CodeSandwich commented on July 29, 2024

I believe that you're referring to this change: 1432518#diff-d79529fa796b868bdba7d0be181244b6d3ee5d3ff0aecb1b5db2d47b78dfb05dL15-L17 and specifically this part of StdAssertion.sol:

-    function fail(string memory err) internal virtual {
-        emit log_named_string("Error", err);
-        fail();
-    }
+     function fail() internal virtual {
+        vm.store(address(vm), bytes32("failed"), bytes32(uint256(1)));
+        _failed = true;
+    }

fail() wasn't removed, it was moved from DSTest to StdAssertion and switched to the native cheatcodes. In the process the fail(err) variant was lost and IMO it could be restored to keep this useful tool around and improve backward compatibility. Previously it was logging err and calling DSTest's fail(), now it could log err and call StdAssertion's fail().

from forge-std.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.