Code Monkey home page Code Monkey logo

Comments (2)

brockelmore avatar brockelmore commented on July 29, 2024 3

The issue here was a solidity issue with the users implementation, where the user was using address b = deployCode("AB.sol:B", abi.encodePacked(a)); instead of: address b = deployCode("AB.sol:B", abi.encode(a));. This resulted in the constructor arg for the address of A being wrong because abi.encodePacked doesnt left pad an address with 0 bytes like abi.encode does. So when B SSTOREs in the constructor, it SSTOREs like so:

// OP [Stack]
AND             [0xffffffffffffffffffffffffffffffffffffffff, <LEFT ALIGNED ADDRESS OF A (should be right aligned)>]
PUSH1(0x00)     [0x00000000042...ce0000000000000]
SSTORE          [0x000..000, 0x00000000042...ce0000000000000]

which results in the wrong address being stored in a, making codesize checks fail in B.

from forge-std.

jgeary avatar jgeary commented on July 29, 2024

Thanks @brockelmore. I can confirm that this was the issue and your solution worked, which was replacing
address b = deployCode("AB.sol:B", abi.encodePacked(a)); with address b = deployCode("AB.sol:B", abi.encode(a)); and generally brushing up on solidity abi encoding docs.

I would recommend adding some documentation or tests that show the argument encoding in action.

from forge-std.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.