Comments (3)
hickeyma
commented on August 29, 2024
1
@tedhtchang You need to fix the linting errors as part of the PR to enable linting for everyone. This way you provide a base that it fully listed that new PRs work from.
from fms-hf-tuning.
hickeyma
commented on August 29, 2024
@tedhtchang Formatting is already enabled: https://github.com/foundation-model-stack/fms-hf-tuning/blob/main/.github/workflows/format.yml
Just need to call the linting as per the formatting pattern.
from fms-hf-tuning.
tedhtchang
commented on August 29, 2024
@hickeyma I ran pylint in my repo. Got the following error:
-----------------------------------
Your code has been rated at 5.84/10
lint: exit 30 (2.25 seconds) /home/runner/work/fms-hf-tuning/fms-hf-tuning> pylint tuning 'scripts/*.py' pid=[206](https://github.com/tedhtchang/fms-hf-tuning/actions/runs/8068335609/job/22040844845?pr=1#step:6:207)5
.pkg: _exit> python /opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
lint: FAIL code 30 (6.42=setup[4.17]+cmd[2.25] seconds)
evaluation failed :( (6.48 seconds)
Error: Process completed with exit code 30.
from fms-hf-tuning.
Related Issues (20)
- Prompt Tuning returns low-quality results HOT 33
- Test SFTtrainer image HOT 1
- feat: standardize the format for metrics, operations, controls in the yamls used by `TrainerControllerCallback`
- bug: AIM package being installed causes the trainer to expect the AIM server to be running. HOT 1
- feat: Expose the trainer state as a trainer controller metric
- feat: Exposed the evaluation metrics for rules within trainer controller
- bug: build output and auto-generated file are not ignored
- feat: support for robust benchmarking of fms-hf-tuning HOT 9
- Contribute ADR for Acceleration Framework Idea
- bug: `eval` is still not safe even with checks for `__` and `"__builtins__": None`
- Add unit tests for tuning/data/tokenizer_data_utils.py HOT 1
- Add unit tests for tuning/sft_trainer.py HOT 1
- Add unit tests to tuning/utils/config_utils.py HOT 4
- Add unit tests for tuning/utils/merge_model_utils.py HOT 4
- Document the linting process.
- bug: Boolean values are represented as strings in default fsdp config translates to True HOT 8
- bug: Using more than 1 GPU causes random stalls and exceptions HOT 9
- Switch to accelerate for Multi GPU HOT 3
- Update launch training for multi GPU training
- Wrong repo - deleted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fms-hf-tuning.