Code Monkey home page Code Monkey logo

Comments (5)

mdevino avatar mdevino commented on August 29, 2024 3

Hi, I'd like to start working on this one.

from fms-guardrails-orchestrator.

declark1 avatar declark1 commented on August 29, 2024 1

Can you share the parameters and text used for this request? From the result above, it appears that the seed was not set in the 2.0 request. I also notice that the 1.0 response returns 99 tokens, which is higher than the TGIS default. Was this parameter explicitly set? If not, I wonder if caikit applies a different max_tokens default.

I know you're picking this up @mdevino, I'd start by confirming these.

from fms-guardrails-orchestrator.

gkumbhat avatar gkumbhat commented on August 29, 2024 1

Thanks @mdevino for picking this up. Please add a unit test for this after fixing. Example: https://github.com/foundation-model-stack/fms-guardrails-orchestrator/blob/main/src/orchestrator.rs#L734

from fms-guardrails-orchestrator.

alanbraz avatar alanbraz commented on August 29, 2024

Problem is that GR API decoding_method value is SAMPLING while TGIS is expecting SAMPLE
Convert in this line and will make the correct call to TGIS and return the correct stop reason. That is wrong because the default is GREEDY.

fms-guardrails-orchestrator/src/models.rs

Line 586 in 4973351

let decoding_method = value.decoding_method.unwrap_or("GREEDY".to_string());

from fms-guardrails-orchestrator.

mdevino avatar mdevino commented on August 29, 2024

After some discussion, let's close this issue and make sure we call the API using "SAMPLE" instead of "SAMPLING", so we align with what TGIS expects.

from fms-guardrails-orchestrator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.