[BUG] AS GITHUB->Actions does not work correctly about fossology HOT 6 CLOSED

There is a new parameter now --report to accept different report formats (TEXT, SPDX_JSON, SPDX_RDF, SPDX_TAG_VALUE, SPDX_YAML). The default value for it is TEXT. However, there is some programming issue bellow

fossology/utils/automation/fossologyscanner.py

Lines 268 to 271 in 7ba0bc4

	parser.add_argument(
	"--report", type=str, help="Type of report to generate. Default 'TEXT'.",
	choices=[member.name for member in ReportFormat], default=ReportFormat.TEXT
	)

Till it is fixed in code, as a hotfix/workaround, you can add the parameter --report TEXT (or any other format) like fossology/fossology:scanner "/bin/fossologyscanner" --report TEXT copyright keyword in the GitHub workflow file.

Thanks, these changes fixed the error. now everything works well!

from fossology.

By adding -e GITHUB_ACTIONS=true in the check-copyright job, you ensure that the GITHUB_ACTIONS environment variable is correctly set

from fossology.

By adding -e GITHUB_ACTIONS=true in the check-copyright job, you ensure that the GITHUB_ACTIONS environment variable is correctly set

Thanks for the suggestion. I tried this before and it doesn't work

from fossology.

There is a new parameter now --report to accept different report formats (TEXT, SPDX_JSON, SPDX_RDF, SPDX_TAG_VALUE, SPDX_YAML). The default value for it is TEXT. However, there is some programming issue bellow

Till it is fixed in code, as a hotfix/workaround, you can add the parameter --report TEXT (or any other format) like fossology/fossology:scanner "/bin/fossologyscanner" --report TEXT copyright keyword in the GitHub workflow file.

from fossology.

There is a new parameter now --report to accept different report formats (TEXT, SPDX_JSON, SPDX_RDF, SPDX_TAG_VALUE, SPDX_YAML). The default value for it is TEXT. However, there is some programming issue bellow

fossology/utils/automation/fossologyscanner.py

Lines 268 to 271 in 7ba0bc4

	parser.add_argument(
	"--report", type=str, help="Type of report to generate. Default 'TEXT'.",
	choices=[member.name for member in ReportFormat], default=ReportFormat.TEXT
	)

Till it is fixed in code, as a hotfix/workaround, you can add the parameter --report TEXT (or any other format) like fossology/fossology:scanner "/bin/fossologyscanner" --report TEXT copyright keyword in the GitHub workflow file.

Hi @GMishx, I believe this can be improved. The default parameter sets the default value for the --report argument and it uses ReportFormat.TEXT, which is an enum member. However, when the user provides a value, it might be a string, not an enum member. Using ReportFormat.TEXT.name as the default value explicitly sets the default value as string "TEXT". This might fix the programming error you quoted. If you are good with the solution i'll open up a pull request. Please take a look.

from fossology.

Using ReportFormat.TEXT.name as the default value explicitly sets the default value as string "TEXT".

Sounds great @dvjsharma, please go ahead.

from fossology.