Comments (29)
@mayank408, Also The Color Yellow for the Date Stamp must be changed to suit better with the App. Maybe a lighter than Primary Shade.
from susi_android.
Looks good 👍
Just a suggestion, can you also replace the toast messages with a Snackbar?
Since we are moving to a material design, it only makes sense to use the new material widgets as well.
from susi_android.
@amitiwary999 i am working on it and am trying to implement it via contextual action bar. But I am facing issuse with RecyclerView. I will highly appreciate if you can help me out in implementing it.
from susi_android.
@addiittya2006 i am trying to delete the messages from application. And sorry for replying too late.
from susi_android.
@nikhilbalyan No worries, at least you tried 😃
Help resolving other issues or suggest new features.
@mayank408 You can go ahead with this.
from susi_android.
@jig08 ya sure
from susi_android.
thanx @jig08 looking forward to give my best 👍
from susi_android.
@nikhilbalyan Would you like to take up this issue ?
from susi_android.
Yes @jig08.
from susi_android.
@nikhilbalyan are we talking about selecting messages here or Results from Susi?
from susi_android.
@nikhilbalyan have you started working on it?
from susi_android.
@daminisatya I would like to work on this issue please assign me..
from susi_android.
@mayank408 @nikhilbalyan is trying to solve this issue.Asked him if he want to work with you on this issue.
from susi_android.
@nikhilbalyan could you please tell me how much work has been on the issue done so that i can help as well if u want to work with me..
from susi_android.
@mayank408 i am facing the same issue as i have mentioned above while integrating CAB with RecyclerView.
from susi_android.
@mayank408 you may take this issue i tried my best but i wasn't able to make it happening. In the onbindview method of chatfeedrecycleradapter class i was obtaining the position of the item clicked but after working around a lot i am stucked now with a lot of git merge conflicts. plz @jig08 assign this to @mayank408. And i am really really sorry for not being able to resolve this issue.
from susi_android.
@jig08 @the-dagger @mariobehling @daminisatya
Is it looking fine or any improvement needed. As of now I dont think there is any requirement for forward and sharing option so I have not implemented that.
The dialog message gets opened on longclick on messages.
from susi_android.
@the-dagger ok sure 👍
from susi_android.
@addiittya2006 ok I will change it in next pr.
from susi_android.
@mayank408 Yep, currently copy
and delete
seems just fine.
- As mentioned, change
toast
tosnackbar
- Change the date color to a slightly lighter shade
Make the above changes in the same PR, in a single commit using the required naming format. Cheers !
from susi_android.
@jig08 @the-dagger @addiittya2006
Is it fine now...
from susi_android.
@mayank408 use coordinator layout. snackbar should lift the layout up instead of covering it.
from susi_android.
Agreed 👍
from susi_android.
@gogeta95 @the-dagger
Should I change this as well.
from susi_android.
yes.. all snackbars should lift UI up.
from susi_android.
@the-dagger @gogeta95 I am facing problem in lifting up the layout when snackbar is opened . I am using coordinate layout but its only lifting the floating action button not the whole layout. Could anyone suggest the solution or someone else would like to work on it.
from susi_android.
@mayank408 You might wish to read this.
http://alisonhuang-blog.logdown.com/posts/290009-design-support-library-coordinator-layout-and-behavior.
I tried this earlier while using the "Internet Connection unavailable" Snackbar, but was not able to achieve that. You may try following.
from susi_android.
@the-dagger We can close this issue , as it is already fixed in issue #203 .
from susi_android.
Good job!
from susi_android.
Related Issues (20)
- Incomplete Unit and UI testing HOT 1
- The sign in page is not working.
- implementation of databinding with live data (best practices)
- Speech to text button on chat activity not working HOT 1
- Search not working in groupWiseSkills, skills refetched every time filters are applied
- The margin is not centered on Skills page HOT 2
- Bump realm-gradle-plugin to 6.1.0 and fix build
- Add TRY button in the Skills List HOT 1
- Warnings of not translated strings in string.xml
- App cannot communicate with api.susi.ai on Android < 5.0 (probably) because TLS 1.2 is not enabled. HOT 2
- App crashes when I enter a question that is not easy answerable
- Remove background location access or document in a video why it is needed HOT 1
- Unable to rate skill when like or dislike option is clicked in the reply from susi.
- ForgotPasswordActivityTest is empty HOT 1
- Conda
- Can we try to port it to Flutter(Google's new UI toolkit) ? HOT 1
- Gradle.properties is giving an error that "set android.useAndroidX=true."
- Dependabot couldn't authenticate with https://jitpack.io
- Can't login
- Any plans for converting this whole apk into kotlin compose?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from susi_android.