The api should be a bit more modular. about email-templates HOT 12 CLOSED

@nathanbowser how might you suggest we rewrite it?

from email-templates.

@nathanbowser rather, could you write in markdown some JavaScript as to how you would like to be able to use emailTemplates? e.g. write a simple Readme example of your idea here

from email-templates.

+1, I'm hitting the max number of files open on my mac when I load test my app. I'm going to try looking into it.

from email-templates.

@niftylettuce Sorry, I'm no longer using this module.

from email-templates.

@nathanbowser what alternative are you using (if any)?

from email-templates.

I switched over to mandrill, which has an api that allows you to define templates, and then pass them your model.

from email-templates.

I do believe consolidate has a template cache, will look into it to close this issue.

from email-templates.

what about

var emailTemplates = require('email-templates');
var template = emailTemplates(templatesDir);

template('my_fancy-email', locals, function(err, html, text) {
})

that would allow to do this:

var emailTemplates = require('email-templates');
var template = emailTemplates(templatesDir);

module.exports = function(locals, done) {
  template('my_fancy-email', locals, done)
});

The parsing can be done once and exporting the thing is much easier.

Or even parse only the template that is requested to be rendered.

from email-templates.

One can use promises, but thats a lot of boiler plate.

Maybe lib should utilize promises.

'use strict';

var path = require('path');
var templatesDir = path.join(__dirname, 'templates');
var emailTemplates = require('email-templates');

var api = {};

var parsedTemplates;
function init() {
  if (parsedTemplates) {
    return Promise.resolve(parsedTemplates);
  }
  return new Promise(function(resolve, reject) {
    emailTemplates(templatesDir, function(err, template) {
      if (err) {
        return reject(err);
      }
      parsedTemplates = template;
      resolve(template);
    });
  });
}

api.confirm = function(locals) {
  return init().then(function(template) {
    return new Promise(function(reject, resolve) {
      template('confirm', locals, function(err, html, text) {
        if (err) {
          return reject(err);
        }
        resolve({
          html: html,
          text: text
        });
      });
    });
  }).then(console.log.bind(console));
};

module.exports = api;

from email-templates.

just created a module for that

from email-templates.

I do believe consolidate has a template cache, will look into it to close this issue.

@jeduan consolidate does have caching, https://github.com/tj/consolidate.js#caching
When passing in the locals object you should be able to add { cache: true, other: 'local variables' } to the locals object to instruct consolidate to cache the template. The consolidate cache does depend on your choice of engine supporting caching.

I'm testing this out right now, assuming it works a simple change to the README should suffice.

from email-templates.

Ok, so v2 is the work of thinking about this. Please check out the branch https://github.com/niftylettuce/node-email-templates/tree/v2.0

The API is now fully Promise-based @StephanHoyer

I'll be closing this. Please reopen if you have any more thoughts.

from email-templates.