Comments (10)
fortran intrinsic function popcnt
looks better. https://gcc.gnu.org/onlinedocs/gfortran/POPCNT.html
from stdlib.
Looks like, but then why is it not used in bit_count_large()
?
from stdlib.
If I remember well, bitset_large
was developed as an externsion of bitset_64
. For bitset_64
, popcnt
cannot be used because some bits may not be used. The solution with btest()
is therefore legitimate. The extension of bit_count
for bitset_large
from bitset_64
was straighfoward.
However, I agree that @PierUgit 's solution or using popcnt
in this loop would be a more efficient implementation.
@PierUgit , do you still have such an implementation (i recognize that my answer is quite late!)? If so, would you like to open a PR with your solution/optimization?
from stdlib.
@jvdp1 I don't have a code ready in Github, I did some tests independently on a code of mine... To be honest I have first to learn how to use fpm and build the stdlib before being able to submit PRs here...
from stdlib.
@jvdp1 I don't have a code ready in Github, I did some tests independently on a code of mine...
Is it ok for you if I submit a PR and ask you for reviewing/testing it?
To be honest I have first to learn how to use fpm and build the stdlib before being able to submit PRs here...
I usually use CMake for building stdlib. However, I agree that the doc is not clear enough for building stdlib
with fpm
. I believe that @jalvesz will submit soon a PR with more detailed information for building stdlib
with fpm
. Your review of this proposal (if you want of course) could be useful too.
from stdlib.
It was actually much easier than expected! I could build stdlib with fpm, modify the code, and add a test case (this routine was not tested). I will submit a PR soon.
I did it from the stdlib-fpm branch, though, and it looks quite behind the master branch...
from stdlib.
It was actually much easier than expected! I could build stdlib with fpm, modify the code, and add a test case (this routine was not tested). I will submit a PR soon.
I did it from the stdlib-fpm branch, though, and it looks quite behind the master branch...
Actually development should be always from the master branch. The branch stdlib-fpm
is just generated for the users. It contains all .f90
generated from the .fypp
files, because fpm
does not support the fypp
preprocessor yet. But it seems fine for your PR.
from stdlib.
Probably I should close the PR and restart from the master branch...
from stdlib.
Probably I should close the PR and restart from the master branch...
Ok. Indeed, probably better and easier.
from stdlib.
Regarding the build with fpm, what I do and want to include as info in the readme is the following:
source ./ci/fpm-deployment.sh
cd stdlib-fpm/
fpm test --profile release
The fpm-deployment.sh scrit takes care of processing the files and creating the stdlib-fpm which contains only .f90
BTW, in my PR regarding str2num I included a change to this script as we realized that the .fypp files in the test folder were not processed.
from stdlib.
Related Issues (20)
- hash_functions test fails on i386: `Segmentation fault - invalid memory reference`
- Request to upgrade Intel-classic compiler in macOS CI
- Add `library` configuration to `stdlib-fpm`
- Massive slow down in docs generation HOT 4
- Unexpected performance of hash maps HOT 8
- python preprocessor HOT 11
- add topic tags `lapack`, `blas`, `linear-algebra` HOT 1
- Improve descriptions of rotm, rotmg, stdlib_srotm, stdlib_srotmg
- Don't repeat names of procedures in descriptions
- stdlib_io_npy, FPM and Rank > 4 HOT 5
- Missing documentation for `LAPACK`-related functions HOT 6
- Adding the logarithmic derivative of the gamma function (digamma) to stdlib_specialfunctions_gamma HOT 1
- example_starts_with prints logical results as binary
- Nonstandard forward reference to 'lk' is not allowed in the same specification part causes compilation errors HOT 4
- Issue/Question about the output of `lstsq` HOT 3
- Building and testing stdlib on WSL1 with two fails HOT 5
- Adding matrix norms to the `stdlib_linalg` module. HOT 8
- Extend `sort_index` interface to allow `int32` index argument HOT 1
- Bug in the complex least-squares solver HOT 6
- Conflict between the pure function `stdlib_iparam2stage` and `openmp` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stdlib.