NullReferenceException in HttpStanzaStream.OnRead about jabber-net HOT 2 CLOSED

I think I got it.

Our implementation of XEP-124 uses two HTTP socket connections. That means that they could call OnRead concurrently.

That OnRead will be proxied through a convoluted path, and eventually dispatched to HttpStanzaStream.

That means that OnRead / OnError methods could be called (almost) simultaneously from two different threads, and that could lead to calling OnRead after OnError.

So, we need to make our HttpStanzaStream completely thread-safe, and make sure it's okay to call event handlers in any combination.

from jabber-net.

@nrevbay, thank you very much for your bug report. It turned out that it was a really nasty bug. My investigation involved much goto, threading issues and convoluted code paths; that was the reason it took me so long to fix the reason of the issue. The changes you proposed in #85 finally were landed (in a slightly different form though) in the develop branch.

from jabber-net.