Code Monkey home page Code Monkey logo

Comments (3)

Viniter avatar Viniter commented on August 16, 2024

Correction: history doesn't actually provide TS definitions, it's provided by DefinitelyTyped (@types/history). It would have to be added as a dependency in order to be used.

Alternatively, the current definition can be updated to match the @types/history one. I can open PR with either one of the fixes. Just tell me which one would you prefer.

EDIT: After looking into it for a bit, the difference between definitions is actually pretty slight, the only thing that needs fixing is the Action type the interface uses. I'll open a PR that fixes it, but you still might consider adding the type dependency, to save yourself the trouble.

from redux-little-router.

parkerziegler avatar parkerziegler commented on August 16, 2024

Thanks @Viniter! Appreciate you taking the time to look into those definitions. Just reviewed your PR, testing locally now. Apologies for the late response, we have only so many hands on OSS at once!

from redux-little-router.

parkerziegler avatar parkerziegler commented on August 16, 2024

Fixed by #289.

from redux-little-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.