Comments (3)
Correction: history
doesn't actually provide TS definitions, it's provided by DefinitelyTyped (@types/history
). It would have to be added as a dependency in order to be used.
Alternatively, the current definition can be updated to match the @types/history
one. I can open PR with either one of the fixes. Just tell me which one would you prefer.
EDIT: After looking into it for a bit, the difference between definitions is actually pretty slight, the only thing that needs fixing is the Action
type the interface uses. I'll open a PR that fixes it, but you still might consider adding the type dependency, to save yourself the trouble.
from redux-little-router.
Thanks @Viniter! Appreciate you taking the time to look into those definitions. Just reviewed your PR, testing locally now. Apologies for the late response, we have only so many hands on OSS at once!
from redux-little-router.
Fixed by #289.
from redux-little-router.
Related Issues (20)
- Warning in build with 14.3 HOT 1
- [MAJOR] Move `immutable/*` re-exports to `immutable/index.js` HOT 1
- Examples give flow errors, (Flowtypes incorrect?) HOT 1
- No underscores in query params. HOT 1
- Trouble using authentication
- Parameter basename in function routerForBrowser does not work if it ends with a slash HOT 1
- There is not enough information in the README HOT 1
- Publish TypeScript types along with package? HOT 4
- Routes ending in a slash are broken
- Infra: Automatically verify index.d.ts HOT 1
- How to test (context troubles) HOT 1
- Link's active state is super opinionated HOT 1
- How to match child route and parent sibling <Fragment>s simultaneously HOT 2
- Missing pathname Flow annotation
- Hot module reloading causes issues? HOT 1
- Url changes, but component doesn't change on push. Correct component shows up on refresh with correct url. HOT 1
- Hash router?
- How to render an overlay on top of main content (2 fragments at once)? HOT 2
- Support redux v4 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-little-router.