Comments (2)
There's no way to get to these two properties, because #a
is completely private and hidden, and getters are defined as non-enumerable, e.g.
Object.keys(new MyClass(1)) // [] empty
const x = new MyClass(1)
for (const key in x) { /* no enumerable keys */ }
for (const key in x.constructor.prototype) {
/* no enumerable prototype keys even */
}
That means there's virtually no enumerable property, e.g. differentiating factor on your class.
In stringification functions I'd personally consider two classes that aren't objects (x.constructor && x.constructor !== Object && keys.length === 0
) to always be unique and compare them by reference equality.
However, in a deep comparison function that's a bad assumption.
There's a solution though :) You can for instance forgo the use of private class properties and make #a
visible, e.g. by naming it _a
.
You could also provide a serialisation function, which is actually quite common:
class MyClass {
// ...
valueOf() {
return this.#a;
}
}
Or alternatively you can use toString
maybe:
class MyClass {
// ...
toString() {
return `[MyClass ${this.#a}]`;
}
}
Currently, react-fast-compare
due to being specialised doesn't support toJSON
though.
from react-fast-compare.
I see. I'll look into using serialization functions or toString
, then. Thanks!
from react-fast-compare.
Related Issues (20)
- Upgrade dependencies
- Add ability to compare functions HOT 9
- module '/node_modules/react-fast-compare/index.js' does not provide an export HOT 1
- Handle anonymous function HOT 2
- Bug: Set compares by reference not value HOT 6
- TypeScript library for react-fast-compare? HOT 9
- Fix exported types so that they work for react-redux HOT 8
- Cannot compare object will null prototype HOT 11
- IE 11: Object doesn't support property or method 'isView' HOT 26
- There should be a 'debug' feature to determine which fields are breaking equality.
- Types: documentation, clean up, and testing
- Audit security alerts HOT 2
- Fix benchmark chart img path
- Ignore Arrow Functions HOT 1
- Re-evaluate project's eslint rules HOT 1
- Update benchmark png HOT 2
- CJS + ESM Question/discussion HOT 6
- Differences in objects with properties that are associative arrays are not detected HOT 8
- Infra: Switch to GitHub Actions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-fast-compare.