Error when replacing with booleans about babel-plugin-transform-define HOT 8 CLOSED

Okay, this fix has been released as 2.1.3! Thanks, all, for reporting, putting a solution together, and nudging this across the finish line!

from babel-plugin-transform-define.

Thanks for opening that issue @tomekzaw .

I can see different cases:

const obj = {
  __DEV__
};
const obj = {
  __DEV__: __DEV__
};
const obj = {
  "__DEV__": __DEV__
};
const obj = {
  ["__DEV__"]: __DEV__
};

Should output:

var obj = {
  "__DEV__": true
};

Meanwhile

const obj = {
  [__DEV__]: __DEV__
};

Should be the only one that also affect the key

from babel-plugin-transform-define.

Agreed, in my view [__DEV__]: __DEV__ should see the key being replaced as the [] indicate to me, it is calculated where the others are just strings or non replaceable keys.

from babel-plugin-transform-define.

Hi @Titozzz - thanks for resurfacing this. I'm a bit swamped this week, but will try to check this out first thing next week!

from babel-plugin-transform-define.

This behavior description is accurate.

So, we tackled things with bindings in #81

I'm not totally sure if we should skip object keys or if there are legitimate use cases to replace those.... Thoughts @carloskelly13 @gksander ?

As an aside, if you switch to string keys, you can get an equivalent, non-error output:

const obj = {
  "__DEV__": __DEV__
};

outputs to:

var obj = {
  "__DEV__": true
};

from babel-plugin-transform-define.

Hello there, gentle nudge to the issue, since I feel we all agree on the problem, what are the steps moving forward, should we expect you guys to fix it at some time or will you want a pull request?
No idea what this issue would take to be fixed, but happy to give a hand!

cc @ryan-roemer @carloskelly13

from babel-plugin-transform-define.

Went ahead and created the PR

from babel-plugin-transform-define.

gentle nudge @ryan-roemer @carloskelly13 @gksander

from babel-plugin-transform-define.