Code Monkey home page Code Monkey logo

Comments (6)

drewfish avatar drewfish commented on May 25, 2024

Note that in commit 5c0df8 (no PR?) that the factory is called multiple times. This means that different module systems will have different copies of the handlers. This is probably OK because there isn't much state (caches, etc) shared between handlers anyway.

from handlebars-intl.

caridy avatar caridy commented on May 25, 2024

yeah, I thought that was weird. Why should we care about using intl-messageformat from the require?

@drewfish in a conversation with @ericf we talked thru getting all these packages to be ES module that transpile to the different module systems, and that will help I think, but we need to continue that conversation.

from handlebars-intl.

ericf avatar ericf commented on May 25, 2024

Oh, I meant to push to my fork. Sorry, I did a Git screwup.

from handlebars-intl.

ericf avatar ericf commented on May 25, 2024

I can revert this and on master and move it to a proper PR.

from handlebars-intl.

ericf avatar ericf commented on May 25, 2024

@drewfish @caridy reverted on master and created PR #25 for this.

from handlebars-intl.

ericf avatar ericf commented on May 25, 2024

This has been resolved. The Node.js version now depends on intl-messageformat, while the browser version has all its dependencies bundled together.

from handlebars-intl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.