Liana totally overrides pre-existing cors configurations about forest-express HOT 4 CLOSED

Hi @Shahor, I am not convinced that the liana overrides the cors configuration of your server.
Maybe it is a configuration issue.

Can you detail how (in which order) you declare your middlewares to give us some insights about what the issue is?

Thanks for your help.

from forest-express.

Hello,

https://github.com/ForestAdmin/forest-express/blob/devel/src/index.js#L115-L119

If I'm not mistaken, this bit of code overrides whatever cors configuration was already set

from forest-express.

Hi @Shahor,

Can you please 🙏answer to my previous questions about the order of your middlewares (your own CORS and ForestAdmin init)?

We use our own tool in our express servers and don't observe such issues but we use an undocumented liana initialisation configuration:

Liana.init({
  expressParentApp: app, // Express parent app
  envSecret: process.env.FOREST_ENV_SECRET,
  authSecret: process.env.FOREST_AUTH_SECRET,
  sequelize: Sequelize,
  connections: [sequelize], // Array of sequelize connections
});

Let me know if it helps

from forest-express.

Hi @Shahor, this is fixed in v5 lianas.

Feel free to reopen this ticket if the issue persists after the upgrade.
🌲🌲🌲

from forest-express.