Body parsing middleware runs even if path does not match a forest admin route about forest-express HOT 5 CLOSED

Hi @dursk, Thanks for the great feedback!

Maybe the use of the undocumented expressParentApp property would fix this problem.
This property enables the liana to generate an express sub-app dedicated to the Forest API (See here)

The declaration should be done like this:

const Sequelize = require('sequelize');
const sequelizeDatabaseConnection = new Sequelize(process.env.DATABASE_URL, databaseOptions);

Liana.init({
  expressParentApp: app, // NOTICE: Your Express app.
  envSecret: process.env.FOREST_ENV_SECRET,
  authSecret: process.env.FOREST_AUTH_SECRET,
  sequelize: Sequelize,
  connections: [sequelizeDatabaseConnection], // NOTICE: Array of database connections
});

I think this initialisation will prevent the behaviour you described but I might be wrong.

Let me know!

from forest-express.

@dursk, did it help?

from forest-express.

I ran into the same issue, using expressParentApp did not help.

from forest-express.

Hi @antogyn, you're right, it does not.
We need to restrict the generic configuration we made (https://www.npmjs.com/package/body-parser#expressconnect-top-level-generic) to Forest routes only (https://www.npmjs.com/package/body-parser#express-route-specific)

from forest-express.

Hi @dursk @antogyn, this is fixed in v5 lianas.

Feel free to reopen this ticket if the issue persists after the upgrade.
🌲🌲🌲

from forest-express.