Code Monkey home page Code Monkey logo

Comments (4)

HarleyAppleChoi avatar HarleyAppleChoi commented on June 7, 2024

@RiccardoM Good. And then it would be like:

  1. block operation on x/consensus?
  2. Take the latest block time from database
  3. Calculate block time
  4. Put it into database

I think putting block height on table should be a good idea along with timestamp

from callisto.

RiccardoM avatar RiccardoM commented on June 7, 2024

@HarleyAppleChoi Yes, having a block operation inside x/consensus seems the best thing to do. The steps you described are correct 💯

from callisto.

kwunyeung avatar kwunyeung commented on June 7, 2024

@RiccardoM the calculation is correct but only the overall average block time has to be calculated on every block, which

average_time = (BlockTime - GenesisTime) / BlockHeight

And I suppose the other average block times can be done on every min, every hour and every day instead of on every new block. In the current version, we have a timer dispatch a function every second. If the current time is at 0 second of every min, 0 second of every hour and 00:00 of every day, it will make those calculations.

from callisto.

RiccardoM avatar RiccardoM commented on June 7, 2024

@kwunyeung Great, thanks!

@HarleyAppleChoi Please implement the calculations as periodic operations then. Leave only the overall average one (the one against the genesis time) inside the block handler.

from callisto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.