`type_safe::visit` doesn't return references about type_safe HOT 4 CLOSED

I think this is happening because std::common_type decays the result type.

from type_safe.

@SuperV1234 just out of curiosity, why would you need visit to return a reference or any other non-decayed type?

from type_safe.

@verri: why not? Here's a weird example from the top of my head:

vector<int> user_ids;
vector<int> group_ids;

auto msg_target = get_target_msg();
auto msg_query = get_query_msg();

auto& target = match(msg_target,
    [](UserIds)  -> auto& { return user_ids; },
    [](GroupIds) -> auto& { return group_ids; }
);

apply_query(msg_query, target);

You don't know how clients of visit are going to use it, there might be a good reason to return a reference.
Also, that's how std::visit and boost::visit behave, so consistency is a plus.

from type_safe.

Sounds a good reason for me.

from type_safe.