Mixed return values with colors_returned option about pleasejs HOT 6 CLOSED

I see three options here:

• Change the function to always return an array (so that people don't have to convert the return value for consistent results)
• Don't change the function (I think this makes the return value more intuitive)
• Make a wrapper around the function that always returns an array (best of both worlds, might seem like overkill)

That's just my opinion, of course.

from pleasejs.

How is returning mixed type values intuitive? In my opinion functions should always return same type values.

from pleasejs.

I agree with @rikukissa here. The function should always return an array for consistent results.

from pleasejs.

I'll just make it always return an array it's NBD. I was trying to save people time but if it ends up being a pain it's clearly not operating as designed.

Jordan Checkman

On Jul 30, 2014, at 5:00 PM, Kyokou [email protected] wrote:

I agree with @rikukissa here. The function should always return an array for consistent results.

—
Reply to this email directly or view it on GitHub.

from pleasejs.

👍

from pleasejs.

Fine by me.

from pleasejs.