Reconnects broken since 1.4 about redis-sentinel HOT 5 CLOSED

Or you could keep a clone of your @sentinels_options as @original_sentinels_options and do:

def try_next_sentinel
  sentinel_options = @sentinels_options.shift
  if sentinel_options
    # ...
  else
    @sentinels_options = @original_sentinel_options.clone
    raise Redis::CannotConnectError
  end
end

from redis-sentinel.

@dim I have fixed in HEAD code, please try and let me know if it works

from redis-sentinel.

Hmm, it works but I am a little concerned about the logic in the approach:

def try_next_sentinel
  sentinel_options = @sentinels_options.shift
  @sentinels_options.push sentinel_options
  if sentinel_options
    ...
end

Because you are pushing the options straight back into the array, sentinel_options can never be nil, so you can safely reduce the method down to:

def try_next_sentinel
  sentinel_options = @sentinels_options.shift
  @sentinels_options.push sentinel_options
  @logger.debug "Trying next sentinel: #{sentinel_options[:host]}:#{sentinel_options[:port]}" if @logger && @logger.debug?
  @current_sentinel = Redis.new sentinel_options
end

from redis-sentinel.

@dim thanks, I have update the code and released 1.4.1 version.

from redis-sentinel.

Hmm, sorry, we made a mistake while testing, seems like you should yank 1.4.1. Will send a patch request shortly.

from redis-sentinel.