Code Monkey home page Code Monkey logo

Comments (2)

stefanprodan avatar stefanprodan commented on August 14, 2024 2

I think all providers should have a validation func that could be called inside the controller reconciliation. If the validation fails, the ready status should be set to false with the validation error as the message.

from notification-controller.

phillebaba avatar phillebaba commented on August 14, 2024

So this can be considered either a documentation or validation issue.

The thing is that only some provider types require that channel to be set, and will fail if it is left empty. While other provider types do not.

Either way the errors needs to be made available in a more prominent location other than the logs. One option may be to expose the initialization errors as events in the provider resource.

from notification-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.