Comments (2)
I think all providers should have a validation func that could be called inside the controller reconciliation. If the validation fails, the ready status should be set to false with the validation error as the message.
from notification-controller.
So this can be considered either a documentation or validation issue.
The thing is that only some provider types require that channel to be set, and will fail if it is left empty. While other provider types do not.
Either way the errors needs to be made available in a more prominent location other than the logs. One option may be to expose the initialization errors as events in the provider resource.
from notification-controller.
Related Issues (20)
- Insuffecient Slack Integration Docs HOT 9
- add namespace filter '*' HOT 1
- Kustomization not applying patch HOT 1
- Teams integration via Proxy HOT 5
- The token field should be excluded from the alert payload
- feat: workflow_dispatch approach for GitLab HOT 3
- Invalid address error in googlepubsub-provider HOT 7
- Receiver match on labels HOT 2
- The Provider API docs uses deprecated API versions
- Panic while using bitbucketserver provider for git commit status HOT 3
- Grafana annotation for Kustomization does not show revision hash HOT 3
- Telegram notification sometimes don't work
- Alert: "error":"postMessage failed: failed to execute request: context deadline exceeded" HOT 1
- Bitbucket Server Provider does not support custom SSH port or HTTP context path HOT 4
- Add alternative key name for the commit status secret HOT 1
- notification controller does not strip new line and the end of URL
- [RFC-0006] Implement CDEvents Receiver type HOT 1
- Allow 'all namespaces' in eventSources
- Pod support for alerts HOT 1
- Alerts sent to Alertmanager contain timestamps as labels, preventing alert grouping HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notification-controller.