Kustomize controller envFrom helm values about helm-charts HOT 6 CLOSED

Without digging to deep into that. Just a question. Does the secret mount does not work her as well?
https://github.com/fluxcd-community/helm-charts/blob/main/charts/flux2/values.yaml#L128

kustomizecontroller:
  # Defines additional mounts with secrets. Secrets must be manually created in the namespace.
  extraSecretMounts: []
    # - name: secret-files
    #   mountPath: /etc/secrets
    #   subPath: ""
    #   secretName: secret-files
    #   readOnly: true

from helm-charts.

My understanding is that would not work because I cannot specify an environment variable within the controller for it to pull from the secret mount. Also I thought it might be more confusing to go a different route than what the flux documentation specifies.

from helm-charts.

@dwerder - If there are no other questions, I am happy to create a pull request, but I believe I need someone to sign off first. Is that correct? Thanks!

from helm-charts.

please open the PR you need to sign your commit for example git commit -sm "commit with dco" thanks

from helm-charts.

please open the PR you need to sign your commit for example git commit -sm "commit with dco" thanks

Thanks @haarchri, pull request is ready: #36

from helm-charts.

please open the PR you need to sign your commit for example git commit -sm "commit with dco" thanks

Thanks @haarchri, pull request is ready: #36

Closed the pull request per convo with @dwerder and he offered to open a new one.

from helm-charts.