Error: The Ticker must be disposed before flutter: calling super.dispose about backdrop HOT 9 CLOSED

This fix/feature has landed with v0.5.3 on pub.dev.

from backdrop.

If you pass animationController to BackdropScaffold, the dispose responsibility is of the outer widget. Ideally this is how it should be and therefore _shouldDisposeAnimationController flag was added.

The Ticker was created according to logs in BackdropScaffoldState.initState (package:backdrop/scaffold.dart:397:9) which is the following:

So, the _animationController is initialized inside the widget state (and not passed) in that case, _shouldDisposeAnimationController will be true and will be disposed of, when the widget disposes.

from backdrop.

@felixwortmann you are right.

Actually I ask myself why _shouldDisposeAnimationController is needed at all. In my opinion it could also be removed, and the dispose method changed as follows:

@override
  void dispose() {
    _animationController?.dispose();
    super.dispose();
  }

It should work as well, wouldn't it? @daadu

from backdrop.

@WieFel that is exactly what I meant. I already created a pr, you can just try it out.

from backdrop.

@felixwortmann "some how" the dispose is not being called, my suspect is in the BackdropScaffoldState.dispose, super.dispose is called before controller.dispose.

Simply, interchanging that should work. The dispose of BackdropScaffoldState Should be the following :

  @override
  void dispose() {
    if (_shouldDisposeAnimationController) _animationController.dispose();
   super.dispose(); // this one at last
  }

from backdrop.

@felixwortmann Can you confirm, if the above code works for you?

from backdrop.

@felixwortmann Can you confirm, if the above code works for you?

That works for me. super.dispose() should just be called after

if (_shouldDisposeAnimationController) _animationController.dispose();

from backdrop.

I just updated my PR, can you take a look at it?

from backdrop.

Fixed with #84

from backdrop.