Code Monkey home page Code Monkey logo

Comments (18)

NamelessCoder avatar NamelessCoder commented on July 23, 2024

Hi Benjamin,

This should be doable. It could be added as a generic property on every field type - but I'll have to think about the proper way to filter these fields when merging the inheritance tree.

Cheers,
Claus

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Hi Claus,

I have a similar problem. In my current setup with fluidpages, once a page related flux value is set on a subpage it can't be reverted to inherit from the parent page again. I am using TYPO3 6.0.4 and the current masters of flux, fluidpages and vhs. Can you help? This is what I have:

<flux:flexform.field.file name="headimg" allowed="jpg" label="Headimage" maxItems="1" />

Cheers
Björn

from flux.

NamelessCoder avatar NamelessCoder commented on July 23, 2024

Hi Björn,

The "file" type field should be cleared when you remove all files. An empty value should allow inheritance from parent. If there is a problem I would look for it in \Tx_Flux_Provider_AbstractConfigurationProvider::getMergedConfiguration - there's a chance the parameters for TYPO3's internal merge+overrule function aren't correct. Or it could simply be that we should check for empty values and manually remove them before merging...

Hope this helps!

Cheers,
Claus

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Hi Claus,

unfortunately not. The selected value can't be cleared thus inheritance is not possible. Someone else reported the same behavior in the forum. The second boolean in array_merge_recursive_overrule() should allow empty values when true but it doesn't help. Do you have another idea maybe? I'm not so deep into flux yet as you might have noticed the other day...

Cheers
Björn

from flux.

NamelessCoder avatar NamelessCoder commented on July 23, 2024

I think I have the perfect solution - let me work on that for a short while, I'll get back to you ;)

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Great, thanks. If this solution doesn't affect the original issue as well we should delete our comments to not hijack the thread which would then again be my bad.

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

I just tested again and it seems one of my commits from yesterday's cleaning routine fixed the 'cannot clear group field' issue =)

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

...which still doesn't seem to fix the inheritance issue. :\

from flux.

s-ude avatar s-ude commented on July 23, 2024

Not sure if my problem is related to this one, but I am not able to clear any field built via flux:flexform.field.text or flux:flexform.field.file. The value doesn't seem to be inherited, as the parent doesn't have a value either. But when clearing such a field the empty value simply isn't stored.
I've tried to use the branch given by Claus, but it didn't help. Is this a known problem?

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Hi @s-ude,

this very much seems to be related. I will do some more tests in my config.

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

@s-ude could you please try the current master to confirm the fix? Thanks in advance.

Cheers
Björn

from flux.

s-ude avatar s-ude commented on July 23, 2024

@dreipunktnull Unfortunately the patch did not work for me. I've updated flux, fluidpages and fluidcontent from their current master branches. I'm still not able to save those empty fields.

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Hm, thanks @s-ude. Seems we need to do some more testing.

from flux.

s-ude avatar s-ude commented on July 23, 2024

Are you able to reproduce my problem? It seems to be a quite simple setup. Just a few new fields for pages via flux:flexform.field, enter a value, save the page and then try to clear the field again. Is the reproduction really that simple?

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Are you able to reproduce my problem?

The thing is I am not :\ It's working for me.

from flux.

s-ude avatar s-ude commented on July 23, 2024

Ah, okay, hm. Then maybe there is another component at my installation which is causing the trouble or maybe I used the viewhelper wrongly. I will investigate a bit more into this as soon as I find the time to do so.

from flux.

bjo3rnf avatar bjo3rnf commented on July 23, 2024

Hi @s-ude,

there have been quite a number of commits recently regarding this issue. Would you mind testing again with all current masters if it has been fixed for you now? In my opinion this issue could be closed.

Thanks in advance.

Cheers
Björn

from flux.

NamelessCoder avatar NamelessCoder commented on July 23, 2024

Hi @s-ude and @benjaminrau,

I'm taking the liberty of closing this one since merging the bunch of fixes all related to inheritance. As always (goes without saying) if you experience issues still, do feel free to reopen the issue.

Cheers,
Claus

from flux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.