Code Monkey home page Code Monkey logo

Comments (3)

NamelessCoder avatar NamelessCoder commented on July 3, 2024

Hi Tommy,

Since I'm lacking a test environment for this specific thing, would you mind testing this suggested fix:

/**
 * check for versions of TYPO3 which do not consistently pass $fieldName
 *
 * @return boolean
 */
public static function assertHasFixedFlexFormFieldNamePassing() {
    return self::assertCoreVersionIsAtLeastSixPointZero();
}

I believe it's a better solution, given that the bugfix that is supposed to fix this field name passing most likely will not be fixed anytime soon (and once it is fixed, the proper versions which fixes it will be known).

Cheers,
Claus

from flux.

dreadwarrior avatar dreadwarrior commented on July 3, 2024

Hi Claus,

thanks for your feedback & your fix proposal. I think this fix is not necessary now, as 4.7.8 is available since some days.

Can you please close this issue because fetching of field values from the page flexform is working now.

As a side note I'd like to add that in 4.7.8 the frontend will throw an exception if a dynamic layout name ("{settings.layout}") is in use and the flexform field is named like "settings.myFancySetting".

Blessings,

tommy

from flux.

NamelessCoder avatar NamelessCoder commented on July 3, 2024

Hi Tommy,

Actually there is still an issue in the core which is not fixed: https://review.typo3.org/#/c/16022/ pending for quite a while now and it doesn't look like it will be part of 4.7.8 either. The sad thing is that the field name is passed in some cases and not in others, which means that in 4.x there's no other choice currently than to assume the field name is not passed. You are most certainly welcome to push for merging the TYPO3 core change but I'm afraid I am out of patience with the core review process.

The good news is that on 6.0+ this has been fixed completely. By simply replacing a core class.

I'll include the patch and wait for whenever somebody decides to merge the nobrainer commit which changes a single line in the core...

Cheers,
Claus

from flux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.