Code Monkey home page Code Monkey logo

Comments (2)

rmelick avatar rmelick commented on May 28, 2024 1

Agreed. I just encountered this issue in RawSocketSender. Our log file filled up the filesystem with messages like the following:
ERROR 16-04-20_14:16:18 [pool-1-thread-1] o.f.l.s.RawSocketSender send Cannot send logs to /192.168.128.1:24224
It seems that the RawSocketSender was having issues flushing the buffer. Every log message that was sent in to fluentd (including these messages sent by RawSocketSender) would attempt to trigger another flush, which would fail and send the error again.

It seems like there could be several options to improve this. Any preferences, and I can create a pull request?

  1. Throttle / rate limit the number of times RawSocketSender will print this message.
  2. Move the error message into the flushBuffer() method inside the enableReconnection if statement. This would at least limit the error message to only as often as it attempts to reconnect, instead of on every log message.
  3. Configure our system to explicitly filter or limit log messages from the RawSocketSender or other fluentd classes. We are actually using logback instead of directly using fluentd.

It also seems like the send() method could be simplified. It's currently calling flush() twice if the pending buffer is full. It seems like it might only need to call flush() once, and only if the pending buffer is full.

from fluent-logger-java.

pontello avatar pontello commented on May 28, 2024

I am having the same problem. RawSocketSender shouldn't have a Logger instance capable of writing logs himself otherwise it will have an infinite loop.
public class RawSocketSender implements Sender { private static final Logger LOG = LoggerFactory.getLogger(RawSocketSender.class); }
As a quick solution I've downloaded RawSocketSender and removed all LOG.* calls.

from fluent-logger-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.