Comments (2)
Agreed. I just encountered this issue in RawSocketSender. Our log file filled up the filesystem with messages like the following:
ERROR 16-04-20_14:16:18 [pool-1-thread-1] o.f.l.s.RawSocketSender send Cannot send logs to /192.168.128.1:24224
It seems that the RawSocketSender was having issues flushing the buffer. Every log message that was sent in to fluentd (including these messages sent by RawSocketSender) would attempt to trigger another flush, which would fail and send the error again.
It seems like there could be several options to improve this. Any preferences, and I can create a pull request?
- Throttle / rate limit the number of times RawSocketSender will print this message.
- Move the error message into the flushBuffer() method inside the enableReconnection if statement. This would at least limit the error message to only as often as it attempts to reconnect, instead of on every log message.
- Configure our system to explicitly filter or limit log messages from the RawSocketSender or other fluentd classes. We are actually using logback instead of directly using fluentd.
It also seems like the send() method could be simplified. It's currently calling flush() twice if the pending buffer is full. It seems like it might only need to call flush() once, and only if the pending buffer is full.
from fluent-logger-java.
I am having the same problem. RawSocketSender shouldn't have a Logger instance capable of writing logs himself otherwise it will have an infinite loop.
public class RawSocketSender implements Sender { private static final Logger LOG = LoggerFactory.getLogger(RawSocketSender.class); }
As a quick solution I've downloaded RawSocketSender and removed all LOG.* calls.
from fluent-logger-java.
Related Issues (20)
- Bad thread interleaving may cause unexpected crash
- Current Error Handling does not return false on logging errors HOT 3
- NullPointerException when the Fluentd server is down
- API changes report for Fluent Logger HOT 1
- support fluentd with secure_forward HOT 1
- java.net.SocketException: Broken pipe HOT 4
- FluentLoggerFactory not invalidate cache after FluentLogger close
- Calling `.close()` does not clean up instance in `FluentLoggerFactory` HOT 2
- NPE in RawSocketSender HOT 1
- There is no way to set socket read timeout HOT 1
- Conflict with Spring cloud SpringApplication run
- Release 0.3.4? HOT 2
- Connection Reset on calling Fluentlogger.log() HOT 3
- Conflict with Spring Webflux
- How to pass credentials to connect remote fluentD aggregator HOT 1
- Null Pointer Exception with slf4j-log4j12-1.7.30 (Fluent-logger incompatible with the new version) HOT 3
- is this libarary can be used for fluent-bit? HOT 1
- log4j JNDI vulnerability HOT 4
- Add Support For Unix Domain Sockets HOT 1
- Is this library still maintained?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent-logger-java.