Comments (7)
Some more info: this problem fit 'git bisect' really well, since checking the window's w() value could be done after the resize() to detect the failure condition, without ever needing to open the GUI.
It zeroed in on this commit:
c66caf5dce9331fd3e011873711a768adb28cf9d is the first bad commit
commit c66caf5dce9331fd3e011873711a768adb28cf9d
Author: ManoloFLTK <[email protected]>
Date: Sun Apr 7 09:09:33 2019 +0200
Simpler implementation of Fl_Cocoa_Window_Driver::resize()
from fltk.
Oh, and for what it's worth, here's the bisect operation that was done:
1. Modified the resize.cpp program, adding this one line above Fl::run() to detect the error:
if ( window->w() == 25 ) exit(1); else exit(0); // exit(1)=FAIL, exit(0)=OK
2. Created a script called 'bisector' in the fltk directory with the contents:
#!/bin/sh
make clean && ( cd src ; make -j 4 ) && ( cd test ; ../fltk-config --compile resize.cpp )
test/resize
exit $?
3. Ran git bisect with the start/end commits from the fltk main directory using:
git bisect good 6838814f9e6433fc93ff73f4415fe30bbd7ed326
git bisect bad 23484c30a9126dcda3f589cd63e3fe2ec8b41c98
git bisect run ./bisector
from fltk.
That should be fixed now.
from fltk.
Great, the window size is fixed.
But there's still maybe a problem: if I scale the test program with e.g. Cloverleaf(+), the window contents disappears.
(I noticed this same issue when I tried applying my own fixes, so I knew to check for it)
from fltk.
That should be "really" fixed now.
from fltk.
Confirmed!
The combination of commit d068fbf and commit 83bd04e solved the issue, thanks Manolo.
from fltk.
FTR: the mention above in issue 427 is irrelevant (unintended).
from fltk.
Related Issues (20)
- needing the set of C++ root or top classes of FLTK 1.4 HOT 4
- fltk.org is down HOT 4
- Bug in callbacks generated by fluid on macOS using system menu bar inside C++ Classes HOT 22
- Discrepant behaviour between Fl_Choice and Fl_Input_Choice HOT 19
- fltk 1.4.x: Fl_Browser unexpected display of empty lines ("@." vs "") HOT 3
- Adding /Xcode to .gitignore in FLTK HOT 2
- Fl_Window::get_size_range() HOT 1
- CMake's INCLUDES adds CMAKE_PREFIX_PATH before staging area leading to problems between .H and .cxx files on API changes HOT 6
- Wayland sends wrong events after an FL_DRAG of a top window. HOT 17
- Problems when using PNG images compiling on a Mac with STANDARD ARCHITECTURE (Apple Silicon + Intel) HOT 12
- Zero-sized borderless window causes high cpu usage on windows HOT 4
- Fl::screen_work_area under Wayland does not take into account the title bar or dockbar when at the bottom HOT 1
- Child Windows under Wayland are clipped on resizing or on showing when placed partially outside the main window HOT 91
- A widget's Drag and Drop does not work when dragging an url from Chrome on Linux HOT 14
- Changing FLTK's default color pallete effects how widgets and opengl child drawings are composited on Wayland HOT 7
- Wayland Memory Leak: one leak (16 bytes) per key press HOT 4
- Fl_Pack should override clear() to set resizable(0) HOT 2
- Allow replacing an element of an Fl_Group (without deleting it) HOT 3
- Wayland hang with a subwindow inside Fl_Flex HOT 1
- Starting a drag from a subwindow does not work on OpenSuse KDE wayland. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fltk.