download, parse and view message (no decrypting yet) about flowcrypt-android HOT 14 CLOSED

f14e433
c7a432e

from flowcrypt-android.

I tried to use your code for parse raw MIME message. And I have some issues.

1. The file raw_mime_html.txt not parsed correctly. I received mimeMessage.getText() == null. Can you see what the problem is?

2. If you do not mind, I would like to make the word "date, subject, from, to" as String constants in class com.flowcrypt.email.test.MimeMessage

3. Can you add the ability to receive dates in timestamp variant (for example 1493972679000)? When I use JavaMail, I received a message date as a Date object. In this case, I can display time in a format convenient for the user, according to his preferences. If I have a timestamp, I can create a Date object manually.

from flowcrypt-android.

346f5de

from flowcrypt-android.

from flowcrypt-android.

from flowcrypt-android.

Does getHtml() also return null?

No, getHtml() return String.
You can see the screenshot.

from flowcrypt-android.

There you go - this MIME message only contains HTML but no plain text.

This is correct behavior. if message.getText() == null, then you display message.getHtml()

from flowcrypt-android.

from flowcrypt-android.

from flowcrypt-android.

Ok, then I'll change the code according to the comments

from flowcrypt-android.

To answer your questions that I didn't address above:

2. You can change MimeMessage or other classes to your liking. A string constant may make sense for title (although a getter may be better, eg mm.getTitle() - up to you). You could also have a Long for date under mm.getDate() or just mm.date etc. But to is more complicated - there may be 5 people that the message was sent to. Each person has an email and a name. How do you want to represent it in a string constant? Same thing for from - there is an email and a name as well, one string may not be sufficient. That's why I thought MimeAddress may be a good way to approach it. Let me know what you think, I'm not really a Java person :)

3. That is a good idea. I have added this functionality now, you can use it as follows:

MimeMessage m = js.mime_decode(read(context.getAssets().open("sample/message.mime")));
System.out.println("Date:" + m.getTimeHeader("date"));

which will print out Date:1493133431000. This is UTC time (amount of milliseconds from the epoch), so you will still need to convert it to local timezone.

from flowcrypt-android.

2. In this case, I mean for example mimeMessage.getAddressHeader(MimeMessage.HEADER_NAME_FROM) instead mimeMessage.getAddressHeader("from"). In Java it is considered a bad practice to write String in the code that can be used more than once. Therefore, they are rendered into constants to reduce the probability of writing a wrong String (for example with missing chars etc.).

public static final String HEADER_NAME_FROM= "from";

3. Very good! I applied this code. It works perfectly.

123573a

I close this task. I have no more questions.

from flowcrypt-android.

Good work!

Yes I thought it may be a bad practice in Java.
mimeMessage.getAddressHeader(MimeMessage.HEADER_NAME_FROM) is perfectly fine and makes sense for the use case, although a bit long :)

Maybe a special class MimeHeader that will just have the constants. Used this way:
mimeMessage.getAddressHeader(MimeHeader.FROM)
mimeMessage.getAddressHeader(MimeHeader.TO)
mimeMessage.getAddressHeader(MimeHeader.SUBJECT)

etc

from flowcrypt-android.

Maybe a special class MimeHeader that will just have the constants.

Yes, I think is a good solution.

from flowcrypt-android.