Rationale for strong dependency on starlette 0.13? about asgi-lifespan HOT 4 CLOSED

Yeap, feel free to close it actually.

I have a fairly large testsuite so there is likely some other stuff going on here.

Cheers for responding fast :)

from asgi-lifespan.

Hi!

Which version of this package were you using? As of 1.0 there is no dependency on Starlette anymore. :) (At least, judging from master.)

from asgi-lifespan.

The latest I guess. But the dependency is part of the requirements.txt file :)

https://github.com/florimondmanca/asgi-lifespan/blob/master/requirements.txt

from asgi-lifespan.

The requirements.txt file is for development dependencies only (Starlette is used for testing). Runtime dependencies are specified in setup.py, and Starlette is not in there. :-)

So at this point I'm thinking the hang might be a proper bug triggered by some specific aspects of your tests setup (or it's caused by something else than asgi-lifespan?)…

FWIW, I wasn't able to reproduce it on the following minimal setup:

import asyncio
from asgi_lifespan import LifespanManager
from starlette.applications import Starlette

app = Starlette(
    on_startup=[lambda: print("startup")], on_shutdown=[lambda: print("shutdown")]
)

async def main():
    async with LifespanManager(app):
        pass

asyncio.run(main())

$ pip install "starlette==0.12.*" "asgi-lifespan==1.*"
$ python example.py
startup
shutdown

from asgi-lifespan.