Duplicate generated type aliases about floating-ui HOT 6 CLOSED

In Derivable's case it has 1 looser property type than it should. As for React, it's just unsightly yeah

from floating-ui.

This seems to be related to microsoft/rushstack#2479

from floating-ui.

Ok, I think I know how to fix Derivable_2 (it needs to use the DOM, not Core type), but I guess we can manually patch React_2 back to React after the types have been generated.

from floating-ui.

Ok, I think I know how to fix Derivable_2 (it needs to use the DOM, not Core type), but I guess we can manually patch React_2 back to React after the types have been generated.

Is it necessary though? it still points to the same export which is the react package, and it's not like React_2 is leaking....
The same question goes for the Derivable_2 is there any type mismatching because of this?

I guess your point is that it looks a little ugly to have that _2 on the typings when someone investigates the typings 😅. It seems to be an open issue on API extractor side though, so I'd agree that if we want this gone we'll have to patch it after file generation for sure

from floating-ui.

please assign this issue to me @atomiks , I'll follow up with a PR ASAP

from floating-ui.

I can see that this strategy of adding a suffix is to avoid conflicts, in the case of Derivable_2 is because there's a local definition of Derivable that makes sense to me. In the case of React_2 for some reason API extractor is assuming there's a local definition of React?! that is weird

from floating-ui.