Code Monkey home page Code Monkey logo

Comments (11)

twistedfork88 avatar twistedfork88 commented on June 7, 2024 2

Please refer the link https://titobouzout.github.io/react/tips/inline-styles.html used for inline styles used in react. I think the property for inline style should be WebkitTransform (with a uppercase W).

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

webkitTransform is the right name https://stackoverflow.com/questions/708895/how-to-set-the-style-webkit-transform-dynamically-using-javascript
Which browser are you trying this on? I don't see the warning on chrome.

from recyclerlistview.

tafelito avatar tafelito commented on June 7, 2024

yes, I'm using chrome as well. Not sure why it gives that error on mine then. Just commenting that line it works, but not sure what the implications are.

image

Also I have another issue when I build my project, it complains about not having react-native dependency, where I'm using it on the web. Even if I set the process.env it stills warns at building time. I'm using it within a meteor app. Any ideas?

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

webKit transform is there to support browsers like UC. They don't understand transform property. Removing this warning will require a browser UA check which I don't to be inside the library. Maybe we can accept it as a prop. Regarding the process.env, does it just warns or the build actually fails. In case it does work are you able to get it to render everything fine? Share relevant part of webpack config if possible. Ideally webpack should've taken care of it.
Btw if you're using it on web you might want to check out perfUpgrade branch. We're working on improving things in case of non deterministic rendering.

from recyclerlistview.

tafelito avatar tafelito commented on June 7, 2024

Thanks @twistedfork88 that'd solve the issue.

@naqvitalha regarding the env variable, I'm not using webpack to bundle my project, so I don't have a config file. Even with the warning at build time, the project still runs, but it's a little annoying having that issue if I can prevent it somehow. I know other libraries like styled-components handle the separation btw native and web, or event rnw, where you can then create an alias for it depending where you are using it.

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

thanks @twistedfork88, didn't know about this convention.

@tafelito the idea with process.env was to keep the import location constant. The easiest solution that I can think of is to have something like import { RecyclerListView } from "recyclerlistivew/web" that should do it. That's how styled-compoments does it. With aliases there is a chance that this might happen to someone again since not all builders support aliases.

Will try to get this out in next release.

from recyclerlistview.

tafelito avatar tafelito commented on June 7, 2024

that'd great @naqvitalha thanks!

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

@tafelito try version 0.0.2 . It's a beta. See if it fixes all of your issues.

from recyclerlistview.

tafelito avatar tafelito commented on June 7, 2024

@naqvitalha 0.0.2 looks good! importing form /web did the job!

Thanks!

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

Great! It'll get release within a few days.

from recyclerlistview.

naqvitalha avatar naqvitalha commented on June 7, 2024

Issue fixed in release 1.1.5 (https://github.com/Flipkart/ReactEssentials/releases/tag/1.1.5). Closing.

from recyclerlistview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.