Comments (7)
Alternatives:
- Use a Json parser which supports comments
- Use a Json derivative which supports comments
I don't really like they idea of having configurations in multiple formats for different packages, so if we decide to use YAML or TOML I would like to not use JSON anymore.
from flintmc.
I think giving users the possibility to use their preferred format via annotation would be a nice thing. As the files are not directly accessed by other packages etc, I don’t see a problem there.
from flintmc.
Why do we need comments in the first place? These configuration files are not supposed to be edited manually. Default values should be provided via annotations, not via a file. Just comment in the configuration interface.
from flintmc.
I think comments generally make sense, sometimes you need to edit the configuration manually, either because your game wont start anymore or because some options are hidden from the GUI as they are debug only options.
from flintmc.
Both cases should only be necessary for developers that have access to the original model interface. Debug options should still be visible in GUI, just hiddem behind a "Show Debug Options" setting or something like that. In my opinion it should be considered an implementation detail how and where we store serialized configurations. We might as well use a SQLite databse...
If the game doesn't start because of a configuration issue then that is clearly a bug in the package that is causing the crash. We could consider a "Safe Mode Startup" that automatically uses default configurations for all configs.
Anyways, if you wanna add this feature, go ahead, I'm fine with it, though I really think it is unnecessary and we shouldn't support manual config editing in this way.
from flintmc.
I'm willing to reconsider my opinion on this once (or should I say if) we support serverside modding.
from flintmc.
Yeah, that’s a point where this can be useful. In general, the config system is not depending on Minecraft, so it might be used in other contexts where comments and editing the config directly can be useful.
from flintmc.
Related Issues (20)
- WorldType.canBeCreated true for the debug type
- Sub settings not registered for superclasses
- Better mapping of classes to their obfuscated name
- Fix errors in obfuscated environment
- Add custom display to BooleanSetting
- Automatically add version parameter to annotations (implement, hook, subscribe,...) in preprocessor
- Cache classtransformations (if possible) to improve startup time HOT 1
- Potion API issues
- Create class caching API and cache class remapping
- fix transform errors in obfuscated environment
- @PostSubscribe with ChatSendEvent behaves weirdly.
- fix runtime class transform error
- add support for eclipse compiler
- @PreSubscribe with OpenGLInitializeEvent behaves weirdly
- Custom registered payload channels cannot receive/read payload messages.
- ConcurrentModificationException in the class cache
- Capture Minecraft debug keybindings
- Trim message before dispatching it
- Support for meta packages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flintmc.