[Bindings generator] generates invalid code on c# side about flaxengine HOT 5 CLOSED

The following compiles just fine, are you missing API_STRUCT() from the Attribute struct?

API_CLASS() class GAME_API Item : public Script
{
API_AUTO_SERIALIZATION();
DECLARE_SCRIPTING_TYPE(Item);

    API_STRUCT() struct GAME_API Attribute
    {
        DECLARE_SCRIPTING_TYPE_MINIMAL(Attribute);
    };

    // [Script]
    void OnEnable() override;
    void OnDisable() override;
    void OnUpdate() override;
};

API_STRUCT() struct GAME_API RuntimeItem
{
    DECLARE_SCRIPTING_TYPE_MINIMAL(RuntimeItem);
    API_FIELD() Array<Item::Attribute> Attributes;
};

from flaxengine.

The following compiles just fine, are you missing API_STRUCT() from the Attribute struct?

API_CLASS() class GAME_API Item : public Script
{
API_AUTO_SERIALIZATION();
DECLARE_SCRIPTING_TYPE(Item);

    API_STRUCT() struct GAME_API Attribute
    {
        DECLARE_SCRIPTING_TYPE_MINIMAL(Attribute);
    };

    // [Script]
    void OnEnable() override;
    void OnDisable() override;
    void OnUpdate() override;
};

API_STRUCT() struct GAME_API RuntimeItem
{
    DECLARE_SCRIPTING_TYPE_MINIMAL(RuntimeItem);
    API_FIELD() Array<Item::Attribute> Attributes;
};

I have it in the source but i striped from ishue for redability

[Edit] DECLARE_SCRIPTING_TYPE_MINIMAL is incorect for struct btw

Compiler on c# is yeling abaut this
Item.AttributeMarshaller.Item.AttributeInternal
It needs to be like this
Item.AttributeMarshaller.AttributeInternal

from flaxengine.

I think, for structs you should use DECLARE_SCRIPTING_TYPE_STRUCTURE.

from flaxengine.

found the place for a patch
BindingsGenerator.CSharp.cs:~1640
this will fix it

                        string originalElementType = originalType[0..^2];

                        if (internalType)
                        {
                            // Marshal blittable array elements back to original non-blittable elements
                            string originalElementTypeMarshaller = originalElementType + "Marshaller";
                            //[Nori_SC note]
                            //Find all characters after last . as a example if the c++ type is Class.Struct it will generate a invalid c# code
                            //with will look like this <Class>.<Struct>Marshaller.<Class>.<Struct>Internal
                            //valid code looks like this <Class>.<Struct>Marshaller.<Struct>Internal

                            var startindex = originalElementType.LastIndexOf('.') + 1;

                            string internalElementType = $"{originalElementTypeMarshaller}.{originalElementType[startindex..]}Internal";

from flaxengine.

The final code that reproduces the issue:

API_CLASS() class GAME_API Item : public Script
{
API_AUTO_SERIALIZATION();
DECLARE_SCRIPTING_TYPE(Item);

    API_STRUCT() struct GAME_API Attribute
    {
        DECLARE_SCRIPTING_TYPE_MINIMAL(Attribute);
        API_FIELD() String foo;
    };

    // [Script]
    void OnEnable() override;
    void OnDisable() override;
    void OnUpdate() override;
};

API_STRUCT() struct GAME_API RuntimeItem
{
    DECLARE_SCRIPTING_TYPE_MINIMAL(RuntimeItem);
    API_FIELD() Array<Item::Attribute> Attributes;
};

from flaxengine.