haveSameAspectRatio about kenburnsview HOT 3 CLOSED

Hi alaeri,

Thank you for your PR. I just took a look at your solution and this is something that I already tried before. It'll sure solve the problem you're having now, but it also introduces some problems in other scenarios too. I agree with you that truncating is not a very good solution for the problem, since it is caused by float point precision errors. I'm still thinking about a better way to solve it, but I'll need to dive into all the computation details of the transitions. You're invited to try to come up with this better solution as well. ;)

from kenburnsview.

Hi Flavioarfaria,
It might introduce other issues later... but I believe it is a solution for this function which was mathematically unsound :) Wouldn't it be better to integrate this one and then fix the other issues which arise?

from kenburnsview.

I haven't been able to repro this, but another dev got a stack trace that also threw this exception. @flavioarfaria can you describe the downsides of adding another decimal point of precision? I'm tempted to do that, but don't understand the downsides of doing so.

from kenburnsview.