Spacing field in tmx file is not working about tiled.dart HOT 12 CLOSED

I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled

from tiled.dart.

@ufrshubham interesting, I'm willing to take a look later today.

from tiled.dart.

Any news?

No news, if anyone want to take on this feel free! :)

from tiled.dart.

from tiled.dart.

@spydon I just tried to test that branch but the problem still persists. After debugging I found out that it was failing because spacing and margin parameters were not copied in _checkIfExtenalTsx() method.

Edit: This is required only for cases where an external tileset file is used. For embedded tilesets, original fix should be enough.

from tiled.dart.

I think we dont have any example using that field, so it's very likely broken. I will test this against the new flame_tiled

Ok cool!

from tiled.dart.

Any news?

from tiled.dart.

tiled.dart/lib/src/tileset/tileset.dart

Lines 212 to 213 in dece94d

	(tileWidth! + spacing).toDouble(),
	(tileHeight! + spacing).toDouble(),

This is the reason. Spacing shouldn't be added to the source rectangle. Removing the spacing fixes the issue.

Do you want to put up a PR for the fix? :)

from tiled.dart.

I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?

from tiled.dart.

I see a PR is open for this but it is not approved. Is that not the correct fix for this issue?

I think it was just forgotten. Would be good if someone depended on the branch and tried the fix.

from tiled.dart.

This has been fixed with pull request #41 and I believe has been verified by @ufrshubham

from tiled.dart.

This has been fixed with pull request #41 and I believe has been verified by @ufrshubham

Yes, I've tested that PR and it works.

from tiled.dart.