[Bug] Test Failure in dbt xero package about dbt_xero HOT 7 CLOSED

Hi @ElliottWilson thanks so much for opening this issue!

Would you mind sharing the details of the records that where the test failed? Were these scenarios where different account ids had the same name? If that is the case then I think your proposal for adding account_id to test uniqueness is the right call. If not, I would like to explore the test failure some more.

Additionally, I see you are open to creating a PR 🎉. If the above looks appropriate and adding account_id is the correct fix, then I encourage you to open a PR and our team can review and work to integrate your contribution into the package. Let me know if you have any questions!

from dbt_xero.

Hello @fivetran-joemarkiewicz ! Thanks for the speedy response. Here is an example of the rows that cause the test to fail:

from dbt_xero.

Thanks for sending that over @ElliottWilson! Hmmm that is interesting that we are seeing two records of Retained Earnings. I am getting the suspicious that something else may be going wrong. 🤔

It looks like we have some logic here in the package that generates Retained Earnings as the account name when the following is true:

ledger.journal_date <= {{ dbt_utils.dateadd('year', -1, 'year_end.current_year_end_date') }}

This looks like our package generating the retained earnings record; however, you already have a Retained Earnings account defined. Does the total for the first record (the one with the null account_id) look accurate? If so, we may just need to add a unique account_id for this created record.

from dbt_xero.

Hi @ElliottWilson I just wanted to post back to see if the other account_id total amount looks accurate?

Our team will be happy to add code to ensure this test does not fail, but wanted to confirm that the values were still accurate before moving forward.

from dbt_xero.

Hey @ElliottWilson! Just wanted to dig deeper here before we deploy a test fix--do the amounts for these accounts look accurate?

We're concerned that we could be overengineering a fix for a proper test failure, since there are two records of Retained Earnings showing. Any investigation results you can provide on your end would be great!

from dbt_xero.

Hello @ElliottWilson! Wanted to check back in and see if you were able to investigate and had any thoughts to the above question.

from dbt_xero.

Closing this issue as it has gone stale. Please feel free to reopen if the issue still persists.

from dbt_xero.