Comments (6)
fivetran-joemarkiewicz
commented on August 16, 2024
Hi @clay-walker thanks so much for opening this issue!
You are correct that the documentation for Linkedin ads schema and database variables is inaccurate and something we should update. I noticed you mention you are open to contributing and creating a PR to address this issue. If you are still open to this, we would be happy to review your PR and incorporate your contribution in our next release!
Let me know if you have any questions on the PR process. 🙏
from dbt_ad_reporting.
fivetran-joemarkiewicz
commented on August 16, 2024
Hi @clay-walker we are planning to release a new patch version of ad_reporting v1.0.1 tomorrow. If you would like your contribution to be included I would recommend opening a PR prior to tomorrow afternoon.
Otherwise, we can fold in the change along with our PR #57. Let me know if you have any questions 😄
from dbt_ad_reporting.
clay-walker
commented on August 16, 2024
Hey @fivetran-joemarkiewicz I'd love to contribute. Any guidelines I should be aware of before submitting a PR?
from dbt_ad_reporting.
clay-walker
commented on August 16, 2024
I cloned the repo locally, created a branch and staged my changes. Getting a 403 forbidden when I try to push to the repo. 🙃
from dbt_ad_reporting.
fivetran-joemarkiewicz
commented on August 16, 2024
Hey @clay-walker you will need to fork the repo in order to open a PR against it. I would recommend checking out this discourse post on how to best contribute. Thanks!
from dbt_ad_reporting.
fivetran-joemarkiewicz
commented on August 16, 2024
This has been addressed within the latest release of the package.
from dbt_ad_reporting.
Related Issues (20)
- [Feature] Update metrics spec to be 1.6 compatiable HOT 1
- [Feature] Add geography dimensions to shared data marts HOT 1
- [Bug] Update semantic model name HOT 2
- [Bug] manifest generation error HOT 9
- [Bug] dbt manifest generation failed HOT 7
- [Bug] Manifest generation failure HOT 2
- [Bug] Issue while running facebook_ads transformations with new schema or for a new instance or environment HOT 2
- [Bug] Compilation Error Could not render {{ metric('spend') }} / {{ metric('clicks') }}: 'metric' is undefined HOT 5
- [Bug] Inconsistency in default value for var `twitter_ads__using_keywords` HOT 1
- [Bug] Turning off Apple ads package still runs source freshness HOT 9
- [Bug] Metric arguments need to be renamed HOT 4
- [Bug] Compilation error - duplicate macro name for child packages
- [FEATURE] Missing table 'keyword_report' in dbt Pinterest package HOT 13
- [Bug] ad_reporting 1.2.0 does not work on dbt 1.4.1 HOT 4
- [Bug] Error in int_ad_reporting__url_report.sql HOT 4
- [Feature] Add ability to pass through metrics to final ad reporting models HOT 1
- [Bug] Unable to define database variables using Unity Catalog for Google Ads Source HOT 5
- [Feature] Support multiple connectors from the same source
- [Feature] Add documentation on differences among aggregations across different grains
- [Bug] Add correct variable name (passthrough metric) in `ad_reporting__url_report` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt_ad_reporting.