Code Monkey home page Code Monkey logo

Comments (3)

clinuxrulz avatar clinuxrulz commented on June 12, 2024

Also scan_black which is called in scan will occasionally need to cycle blacks back over the visited white nodes (in the depth direction if that makes sense). So trace needs the capability to loop around and revisit the same nodes. However the trace implementation for RefCell does not revisit the same nodes in a recursive loop-like style when they are already locked for reading.

That means that this library needs its own RefCell separate from the one supplied by the std.

from bacon-rajan-cc.

jrmuizel avatar jrmuizel commented on June 12, 2024

I believe I've fixed the issue that you pointed out in the first comment in 7cd96af.

I don't really follow your second comment. Perhaps you could create a test case that shows the problem?

from bacon-rajan-cc.

clinuxrulz avatar clinuxrulz commented on June 12, 2024

Its been a while since I've looked at this code.
If I remember correctly:
In second comment just means that a user using RefCell will not allow you to visit the same gc node twice in the gc algorithm. Which can break the algorithm with resetting colors etc.
To avoid the problem trace can be done iteratively instead of recursively (add a stack vec from thread local and use it to convert recursive trace into an iterative trace)
If I find some time, I'll wip up a test case to demonstrate the problem.

from bacon-rajan-cc.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.