"Too many DNS queries" about firezone HOT 3 OPEN

@conectado I was able to replicate this with just a ping to github.com and a reload of github.com on a slow network. I'm not sure how many DNS queries ping github.com is supposed to generate, but if the underlying network is slow or dropping them (e.g. hotspot), then somehow this fills the buffer, and then we get log spammed with the error message in the title.

Questions:

• Why is Too many DNS queries printed in each iteration of the eventloop it seems? Shouldn't this correspond to when the actual DNS query was attempted?
• Can we dedup the queries by host?
• Can we increase the buffer much higher? 1,000 or even 5,000 might be more appropriate if we're actually filling up the buffer with valid queries.

When I see this error, the peer is dropped, so we have to get a new resource_intent for things to work again.

from firezone.

• Why is Too many DNS queries printed in each iteration of the eventloop it seems? Shouldn't this correspond to when the actual DNS query was attempted?

It should only be per query but if the browser generates many DNS queries, we will see it a lot.

• Can we dedup the queries by host?

Should be possible, we would need to buffer all incoming queries and answer them once the result comes back.

• Can we increase the buffer much higher? 1,000 or even 5,000 might be more appropriate if we're actually filling up the buffer with valid queries.

Definitely. It was set to a pretty arbitrary number. We should probably also decrease the timeout from 60s to something shorter. Even on a slow network, a DNS query should resolve within 5(?)s?

from firezone.

This seemed to be a weird bug --

Steps to reproduce:

• Connect firezone (macOS)
• Keep browser closed
• ping github.com
• roam networks judiciously

I seemed to be able to hit it with just those steps, which doesn't seem to make sense.

from firezone.