connlib: initialize `Sockets` with factory-fn for making a socket instead of `protect` about firezone HOT 2 OPEN

Odd question but, do the callbacks actually have to be the same on all platforms?

from firezone.

Odd question but, do the callbacks actually have to be the same on all platforms?

I guess that you are asking for the callback in this issue but just in case, for FFI, right now we're in the process of eliminating the callbacks as they are now and we will have a single one, so it won't be relevant. Back then when we defined the old callbacks we decided to try to keep the same interface to have a clearer API.

In this case in particular I find that having a platform-specifc codepath is harder to follow and test, and also to edit since rust-analyzer ignores code-path that are not part of your platform implementation.

Also, in the Sockets definition I think it can be less clear to know what the protect callback does rather than something that's shared among all platforms such as create_sockets. But when I'm looking at the client-specific crates for linux and android I expect to know what the fwmark or protect ffi-callback does.

from firezone.