Code Monkey home page Code Monkey logo

Comments (14)

aaronsaray avatar aaronsaray commented on September 7, 2024 1

I would be open to implementing anything that FirePHP requires.

What would be really cool would be an additional x- header sent on request - of the maximum accepted size of headers in that browser. Perhaps even modify firephp to wait until deconstruct until headers are sent - call get_headers() to calculate the already sent headers, subtract that from the x- header limit, and then truncate? Just spit-balling :) Let me know what I can do to help.

from firephp-core.

PowerKiKi avatar PowerKiKi commented on September 7, 2024

What you describe is exactly what I imagined. It shouldn't be too much huge
work, it is flexible and don't mess with ugly browser detection.

I am willing to work on a pull request if the concept is validated by
firephp team.

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

I am open to adding the detection of Chrome and limiting the data sent in the PHP library. The limit should be done via an option (like the other options) where the option is automatically set if Chrome is detected. If the option was set by the user it should not be changed. We can call the option maxCombinedHeaderSize.

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

Just saw the other comments. If you want to look for a x-wf-option-max-combined-header-size header to set the option that would work as well. The size should be what the browser would accept as maximum and FirePHP can calculate the size of the existing headers minus say 200 characters that may be added by the webserver. We may need to tweak that.

from firephp-core.

PowerKiKi avatar PowerKiKi commented on September 7, 2024

So I pull requested patches for both FirePHP and FirePHP4Chrome. FirePHP new feature is covered by unit tests (tested with PHPUnit 3.7, PHP 5.4). Hope everyone will agree with my changes and that it will be merged :)

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

I have commented on the PRs. This still needs some work.

from firephp-core.

PowerKiKi avatar PowerKiKi commented on September 7, 2024

I stumbled upon an issue and am waiting for advice to keep working on that PR. See https://github.com/firephp/firephp-core/pull/11/files#r4088176

from firephp-core.

PowerKiKi avatar PowerKiKi commented on September 7, 2024

Closing due to lack of interest from core developers.

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

I am going to be looking at this later this year. Will be doing an update to FirePHP on server and client.

from firephp-core.

markusp72 avatar markusp72 commented on September 7, 2024

+1

from firephp-core.

PowerKiKi avatar PowerKiKi commented on September 7, 2024

@markusp72, I wouldn't hold my breath if I were you and move on to another project.

This project has not seen any significant activity in the last 2 years (if not more), and this specific issue was solved in #11, more than 3 years ago, but the maintainers never considered it good enough to be merged. Even though the original code base is really not up to modern standards.

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

I am working on a new Web Extension here: https://github.com/firephp/firephp-for-firefox-devtools

We can bring this functionality into the new extension and update FirePHPCore as things settle down.

I am charging ahead with FirePHP irrespective of other projects (like FirePHP4Chrome) now if that makes any difference.

@PowerKiKi I apologize for your frustrating experience (understandably so) contributing to FirePHP.

from firephp-core.

aaronsaray avatar aaronsaray commented on September 7, 2024

Cool! Just to clarify - I did implement the feature we discussed above in FirePHP4Chrome - even though it was just a suggestion. If that particular implementation changes, I'm open to removing the code and applying a different solution. Just been waiting... glad to hear there's some movement here now :)

from firephp-core.

cadorn avatar cadorn commented on September 7, 2024

Will be solved by: #57

from firephp-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.