Code Monkey home page Code Monkey logo

Comments (9)

russellwheatley avatar russellwheatley commented on May 26, 2024 3

@inceptusp
I've raised this with the firebase iOS team here: firebase/firebase-ios-sdk#12866

from flutterfire.

inceptusp avatar inceptusp commented on May 26, 2024 3

@russellwheatley it may be detecting because of line 44 user.metadata.creationDate has the same attribute name as the fileTimestamp:creationDate... This case could really be a false positive...

About the firebase_messaging, there was a PR to add the privacy manifest to the plugin code because it uses NSUserDefault in the plugin, in addition to the Pod, but the file name is different from apples requirement... it should be PrivacyInfo.xcprivacy but, currently is PrivacyManifest.xcprivacy... https://github.com/firebase/flutterfire/blob/master/packages/firebase_messaging/firebase_messaging/ios/Resources/PrivacyManifest.xcprivacy

from flutterfire.

inceptusp avatar inceptusp commented on May 26, 2024 2

@russellwheatley yes, these are the latest installed pods based on the latest flutterfire plugins versions.

The script we are mentioning is this one from crasowas that automates and prints in a nice way the analysis based on the steps described by stuartmorgan on flutter/flutter#145269. The script analyses pods and dart plugin sources...

from flutterfire.

abbas-at-alt avatar abbas-at-alt commented on May 26, 2024 2

@russellwheatley

firebase-ios-sdk 10.25.0 has fixes for this issue in their latest releases. We will need to bump the version here.

https://firebase.google.com/support/release-notes/ios

from flutterfire.

aggeloskoutanis avatar aggeloskoutanis commented on May 26, 2024

I confirm from my side as well. The following are missing:

FirebaseCrashlytics
Analyzing FirebaseCrashlytics 🎯 ...

💡 Found privacy manifest file(s): 1

[0] ./Pods/FirebaseCrashlytics/Crashlytics/Resources/PrivacyInfo.xcprivacy

API usage analysis result(s): 4

[0] NSPrivacyAccessedAPICategoryUserDefaults:UserDefaults,NSUserDefaults:./Pods/FirebaseCrashlytics/Crashlytics/Crashlytics/FIRCLSUserDefaults/FIRCLSUs

erDefaults.m

[1] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseCrashlytics/Crashlytics/Crashlytics/Handlers/FIRCLSException.mm

[2] NSPrivacyAccessedAPICategoryFileTimestamp:stat:./Pods/FirebaseCrashlytics/Crashlytics/Crashlytics/Helpers/FIRCLSFile.m

[3] NSPrivacyAccessedAPICategoryFileTimestamp:stat:./Pods/FirebaseCrashlytics/Crashlytics/Shared/FIRCLSMachO/FIRCLSMachO.m

🛠️ Descriptions for the following required API reason(s) may be missing: 1

[0] NSPrivacyAccessedAPICategoryFileTimestamp


FirebaseDynamicLinks
Analyzing FirebaseDynamicLinks 🎯 ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 3

[0] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseDynamicLinks/FirebaseDynamicLinks/Sources/FIRDynamicLinks+FirstParty.h

[1] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseDynamicLinks/FirebaseDynamicLinks/Sources/FIRDynamicLinks.m

[2] NSPrivacyAccessedAPICategoryFileTimestamp:NSFileCreationDate:./Pods/FirebaseDynamicLinks/FirebaseDynamicLinks/Sources/Utilities/FDLUtilities.m

🛠️ Descriptions for the following required API reason(s) may be missing: 2

[0] NSPrivacyAccessedAPICategoryUserDefaults

[1] NSPrivacyAccessedAPICategoryFileTimestamp

FirebaseInAppMessaging
Analyzing FirebaseInAppMessaging ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 9

[0] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Analytics/FIRIAMAnalyticsEvent

LoggerImpl.h

[1] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Analytics/FIRIAMAnalyticsEvent

LoggerImpl.m

[2] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Analytics/FIRIAMClearcutUpload

er.m

[3] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Flows/FIRIAMBookKeeper.m

[4] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Private/Analytics/FIRIAMClearc

utUploader.h

[5] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Private/Flows/FIRIAMBookKeeper

.h

[6] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Private/Runtime/FIRIAMSDKModeM

anager.h

[7] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Runtime/FIRIAMRuntimeManager.m

[8] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebaseInAppMessaging/FirebaseInAppMessaging/Sources/Runtime/FIRIAMSDKModeManager.m

🛠️ Descriptions for the following required API reason(s) may be missing: 1

[0] NSPrivacyAccessedAPICategoryUserDefaults

Firebase Performance
Analyzing FirebasePerformance ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 3

[0] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebasePerformance/FirebasePerformance/Sources/Configurations/FPRConfigurations+Pri

vate.h

[1] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebasePerformance/FirebasePerformance/Sources/Configurations/FPRConfigurations.m

[2] NSPrivacyAccessedAPICategoryUserDefaults:NSUserDefaults:./Pods/FirebasePerformance/FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags+

Private.h

🛠️ Descriptions for the following required API reason(s) may be missing: 1

[0] NSPrivacyAccessedAPICategoryUserDefaults


FirebaseRemoteConfigInterop
Analyzing FirebaseRemoteConfigInterop ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 0


FirebaseSessions
Analyzing FirebaseSessions ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 1

[0] NSPrivacyAccessedAPICategoryUserDefaults:UserDefaults:./Pods/FirebaseSessions/FirebaseSessions/Sources/Settings/SettingsCacheClient.swift

🛠️ Descriptions for the following required API reason(s) may be missing: 1

[0] NSPrivacyAccessedAPICategoryUserDefaults


FirebaseSharedSwift
Analyzing FirebaseSharedSwift ...

⚠️ Missing privacy manifest file!

API usage analysis result(s): 0

from flutterfire.

russellwheatley avatar russellwheatley commented on May 26, 2024

Hey @inceptusp - They're all coming from the Pods/ installed via firebase-ios-sdk. Have you tried cleaning out your Pods and reinstalling?

Could you also tell me what tool you're using to analyse projects for privacy manifests? I didn't realise one was available.

from flutterfire.

StevenSnary avatar StevenSnary commented on May 26, 2024

@abbas-at-alt

@russellwheatley

firebase-ios-sdk 10.25.0 has fixes for this issue in their latest releases. We will need to bump the version here.

https://firebase.google.com/support/release-notes/ios

From the release notes it doesn't look like firebase_auth has been updated in the latest version to fixed the following issue/notice using the script noted above:

NSPrivacyAccessedAPICategoryFileTimestamp:creationDate:/Users/userdirectory/.pub-cache/hosted/pub.dev/firebase_auth-4.19.4/ios/Classes/PigeonParser.m

FYI - I have submitted apps to the AppStore recently and for the plugins I'm using the only two that would trigger a warning on App Review with Apple was:

FileTimestamp:creationDate for firebase_auth and
UserDefaults:NSUserDefaults for firebase_messaging - and as you mentioned in your post, it appears as though the firebase_messaging is being patched - but I do not see a patch for firebase_auth

from flutterfire.

russellwheatley avatar russellwheatley commented on May 26, 2024

@StevenSnary - I've just had a look at that file: https://github.com/firebase/flutterfire/blob/master/packages/firebase_auth/firebase_auth/ios/Classes/PigeonParser.m

This seems like a mistake because we don't use any File Timestamp API.

from flutterfire.

russellwheatley avatar russellwheatley commented on May 26, 2024

@inceptusp - thanks for the heads up, I have renamed to PrivacyInfo.xcprivacy 🙏

from flutterfire.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.