Comments (8)
inlined
commented on August 16, 2024
This is strange... I've reproduced once after adding params, but it was stable after that. I can scan the code for anything suspicious but without a reliable repro I may have some difficulty
from firebase-tools.
iq-dot
commented on August 16, 2024
What kind of params did you add? I've seen it rarely work on our CI but 9 out of 10 times it does a full update, I just can't figure out what the issue is. If I ssh into our CI box and deploy, the first deploy is full but the subsequent ones are fine but if I re-create another build using the same code, it does a full update.
Are you also using CircleCI to reproduce or a different method?
from firebase-tools.
inlined
commented on August 16, 2024
I added string params, but it shouldn't make a difference since they're all strings in dotenv anyway. I'm trying to reproduce locally; Circle CI isn't officially in our scope, so I'm trying to reproduce it on my machine
from firebase-tools.
inlined
commented on August 16, 2024
TIL that if you use --only with a function or codebase it disables noops. Does that apply to your case?
from firebase-tools.
iq-dot
commented on August 16, 2024
Nope I don't use --only, I always deploy all functions. I have also tried
with and without --force flag and no difference either.
Could it be an ordering issue with JSONification of env params?
Does the deployment pick up all env variables in the build machine or just
those defined in an .env file?
…On Wed, 27 Mar 2024, 22:59 Thomas Bouldin, ***@***.***> wrote:
TIL that if you use --only with a function or codebase it disables noops.
Does that apply to your case?
—
Reply to this email directly, view it on GitHub
<#6879 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2HQHGSYB2NEN6E7E4UGXLY2NFNVAVCNFSM6AAAAABEWOF4WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGEZDCNBXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from firebase-tools.
inlined
commented on August 16, 2024
I just realized you might be expecting the feature to work differently than it does. Are you expecting that changes to folder1 won't deploy functions in folder2?
The hash check is against the entire source upload (plus dotenv and secret verions). Changes to either folder1 or folder2 will affect all functions in the codebase and change the hash. There's no way to know that your code in folder2 hasn't somehow reached in and modified the code in folder1 without building our own interpreter (e.g. what if folder2 had a utility function that folder1 depended on?). This is why we introduced codebases. If you're able to split your code into multiple codebases, you'll quickly benefit from noops. I fully recognize that this isn't always easily doable since we do not currently support monorepos for common utilities/types; that's a request that's been on our back-burner for a while. We've had some setbacks in implementing it but may be able to pick it up again in a few months.
from firebase-tools.
iq-dot
commented on August 16, 2024
That is exactly what I assumed and your explanation makes a lot of sense.
When deploying the output log states that it's checking which functions
have changed to determine what to upload so I assumed it was checking based
on per function.
So the only way is to split it into codebases otherwise changing any
function code will deploy all? Have I understood that correctly?
…On Wed, 27 Mar 2024, 23:28 Thomas Bouldin, ***@***.***> wrote:
I just realized you might be expecting the feature to work differently
than it does. Are you expecting that changes to folder1 won't deploy
functions in folder2?
The hash check is against the entire source upload (plus dotenv and secret
verions). Changes to either folder1 or folder2 will affect all functions in
the codebase and change the hash. There's no way to know that your code in
folder2 hasn't somehow reached in and modified the code in folder1 without
building our own interpreter (e.g. what if folder2 had a utility function
that folder1 depended on?). This is why we introduced codebases
<https://firebase.google.com/docs/functions/organize-functions?gen=2nd#organize_functions_in_codebases>.
If you're able to split your code into multiple codebases, you'll quickly
benefit from noops. I fully recognize that this isn't always easily doable
since we do not currently support monorepos for common utilities/types;
that's a request that's been on our back-burner for a while. We've had some
setbacks in implementing it but may be able to pick it up again in a few
months.
—
Reply to this email directly, view it on GitHub
<#6879 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2HQHG5TC2OREERSYUV6MTY2NIZ5AVCNFSM6AAAAABEWOF4WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGE2DSMBZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from firebase-tools.
inlined
commented on August 16, 2024
That's correct. If your node module changes, all functions in that node module are updated because there's no way to rule out side effects. I'll add a warning to our documentation about this.
I'm closing the bug to remove it from our tracker, but I can check my GitHub inbox if you post extra comments.
from firebase-tools.
Related Issues (20)
- incorrect continueUrl port printed when using sendSignInLinkToEmail via Firebase hosting emulator HOT 1
- NextJS 14 + Framework hosting: __session cookie not set when deployed
- Functions with the Cloud SQL Node Connector have performance penalty (500–930 ms) for each function unless lazy init a global pool and connector HOT 1
- SignatureDoesNotMatch error when using GOOGLE_CLOUD_QUOTA_PROJECT environment variable HOT 6
- Firebase Hosting HOT 1
- Firebase requires reauth for Google Workspace Accounts HOT 6
- Clearing Emulator Data Does not work in datastore-mode HOT 3
- [firestore-emulator: datastore-mode] Kind query return empty list HOT 1
- Secrets not bound to a function have a value when using the emulator HOT 3
- emulators:exec command runs for long time for tests with `get` command HOT 1
- Workaround of using --force flag when setting min instances to cloud function in non interactive terminal HOT 1
- @angular-devkit/build-angular:browser (app:build:production) is not a recognized builder HOT 14
- next/image External URL Issue with Firebase Hosting HOT 4
- Unhandled error cleaning up build images HOT 1
- Works well locally but 500 error after deployed HOT 3
- Unable to start Firebase emulators HOT 10
- [firestore-emulator: datastore-mode] Namespace queries return empty array
- deploiement de mon dashboard HOT 1
- [Firebase hosting emulator] Rewrite not redirecting for source -> destination rewrite HOT 5
- Next JS images and nested dynamic routes returns 503 error ECONNREFUSED - Timeout HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firebase-tools.