emulator raises "GET" ... "Invalid request, unable to process." on first function call about firebase-functions-python HOT 6 CLOSED

It's probably the healthcheck. To deal with it, I just put this in my https functions:

    if req.method == "GET" and req.path == "/__/health":
        logger.debug("Returning OK to healthcheck")
        return https_fn.Response("OK")

If it's not that, print req.path to find out what it is.

from firebase-functions-python.

@ekalosak Sorry if I misunderstood the issue, but does #134 fix this issue? Seems unrelated to me.

If indeed the issue is this extra GET request triggering the warning log with the None request body, we should probably either try to fix that or if it's not something we can control, at least document it. The PR is still valid, just not sure if this issue should be considered fixed once that's merged in

from firebase-functions-python.

Hello @ekalosak. Could you provide a minimal reproducible example as well as your python version and contents of your requirements.txt?

from firebase-functions-python.

@exaby73 That strikes me as correct.

The next line above in the stack trace is:

/.../venv/lib/python3.11/site-packages/firebase_functions/private/util.py", line 125, in _on_call_valid_
method
>      _logging.warning("Request has invalid method.", request.method)

While I believe you are quite right that #134 will not fix the reported error, I believe the fix is something quite similar. The offending line is in the same util.py.

minimal reproducible example

python -c 'import logging; logging.warning("won't work", ("GET",))'

expected result

--- Logging error ---
Traceback (most recent call last):
  File "/.../3.11.4/lib/python3.11/logging/__init__.py", line 1110, in emit
    msg = self.format(record)
          ^^^^^^^^^^^^^^^^^^^
  File "/.../3.11.4/lib/python3.11/logging/__init__.py", line 953, in format
    return fmt.format(record)
           ^^^^^^^^^^^^^^^^^^
  File "/.../3.11.4/lib/python3.11/logging/__init__.py", line 687, in format
    record.message = record.getMessage()
                     ^^^^^^^^^^^^^^^^^^^
  File "/.../3.11.4/lib/python3.11/logging/__init__.py", line 377, in getMessage
    msg = msg % self.args
          ~~~~^~~~~~~~~~~
TypeError: not all arguments converted during string formatting
Call stack:
  File "<string>", line 1, in <module>
Message: 'asdf'
Arguments: (('GET',),)

Notice that string coercion fails for tuples.

So that's an easy fix of course, just extract the string value from the 1-tuple request.method and 🚀

Regarding the GET request - as berengamble says above that seems likely to be a desirable health check. The desired behavior, I imagine, aught not to be to remove the health check but instead to fix the error in the utility that logs such requests.

from firebase-functions-python.

Fix: #138

from firebase-functions-python.

Fixed by merge of #138 .

from firebase-functions-python.