Mail subject encoding in firestore-send-email about extensions HOT 6 CLOSED

Ok I found that we have to add one more curly braces pair to escape specials char :D

Mail subject should be : "Welcome to {{{name}}}"

https://handlebarsjs.com/#html-escaping

from extensions.

@rphlmr Thanks for the feedback. Looks like you're right yeah, the triple-stash should work in this case.

I'll get a PR sent up soon with the changes (unless you wanted to take a go?).

from extensions.

Actually, I was thinking we could set this in the template compiler, however re-reading what you said I think this is a documentation update.

Maybe in the docs we could add a line below the example:

By default, the extension HTML-escapes values returned by a `{{expression}}`. If you don't want to escape a value, use the "triple-stash", `{{{`.

Taken from: https://handlebarsjs.com/#html-escaping

cc @rachelsaunders

from extensions.

Yes, I think it should be only on the documentation.
It's easier to put it in the template compiler (and transparent for fast doc readers), but if someone wants to escape, it'll no more be configurable.

Last question, do you know why it works without triple-stash in the template body ? (actually it seems that we have 2 diffents behaviours :p )

from extensions.

1. It'd be great to learn the answer to the question from @rphlmr above.

2. A clarification question - this HTML-escaping syntax is only applicable for templates, right?

3. If (2) is true... Since the HTML-escaping syntax is already documented in the handlebar template documentation, I'd prefer to not repeat it in our docs. It seems pretty easy to find in their docs with a quick ctrl-f of their page. If we document this syntax in our docs, then we'd be going down the road of documenting all their syntax.

from extensions.

1. It'd be great to learn the answer to the question from @rphlmr above.

So the reason the subject & body have different functionality is how the email client is handling the data. Your body content will be getting escaped by handlebars, but your email client will be then parsing the HTML entities back into valid HTML (as HTML is allowed in the body).

In the subject, only a string is allowed, so it displays the escaped output handlebars generated.

2. A clarification question - this HTML-escaping syntax is only applicable for templates, right?

Yep, it's applied to the subject, html/text/amp properties sent on each email.

3. If (2) is true... Since the HTML-escaping syntax is already documented in the handlebar template documentation, I'd prefer to not repeat it in our docs. It seems pretty easy to find in their docs with a quick ctrl-f of their page. If we document this syntax in our docs, then we'd be going down the road of documenting all their syntax.

Makes sense, I'll go ahead and close this issue along with the PR.

from extensions.