[BUG] name of resized image is missing original image name if there was no file type extension about extensions HOT 7 CLOSED

Still experiencing this when an uploaded file does not have an extension.

I am aware that I can check whether filename has an extension before uploading, but IMO the resize image extension should be able to handle case without file extension.

Can this be re-opened ?

from extensions.

Hey @emrebicer 👋 - thanks for reporting this issue, will get this looked at.

from extensions.

It seems like this bug only happens when the uploaded file doesn't have a file extension. When there is an extension (.jpg), or even a . at the end of the filename (random-filename.) then it works as expected. The resized image name is {original filename}_64x64.. It seems like the extension is expected and without it, something is getting messed up.

from extensions.

You can set a file extension when using putString by specifying a the file name when creating a storage reference:

const imageStorageRef = firebase.storage().ref('images/space.jpg');
// ...
imageStorageRef.putString(/* ... */) // ..

Is there some other case where it would never set a file extension?

from extensions.

Actually I see it's fixed in #134 :)

from extensions.

You can set a file extension when using putString by specifying a the file name when creating a storage reference:

const imageStorageRef = firebase.storage().ref('images/space.jpg');
// ...
imageStorageRef.putString(/* ... */) // ..

Is there some other case where it would never set a file extension?

After adding ".jpg" at the end of my file names the problem went away. It looks like a proper solution for me. Closing the issue, thank you :).

from extensions.

@Salakar We should support file names without file type extensions. Can you work on a PR to fix this?

from extensions.