Comments (6)
Joe-Dunleavy
commented on August 18, 2024
Hi Kris, I will address this asap.
from fdc3-conformance-framework.
kriswest
commented on August 18, 2024
That only happens if all apps leave and it's an implementation decision in
Finsemble, rather than the standard itself, which doesn't comment on how
long context should or shouldn't stay on channels.
Lemme know how you get on. We're keen to run another test!
K
…On Tue, 25 Oct 2022, 08:53 Joe Dunleavy, ***@***.***> wrote:
Hi Kris, I will address this asap. My understanding was that the broadcast
context was dropped if the app that is broadcasting leaves the channel --
as is the case between each test.
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM7PBHJLHGCXD57KDSA3U3WE6GWFANCNFSM6AAAAAARNHZAVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from fdc3-conformance-framework.
Joe-Dunleavy
commented on August 18, 2024
@kriswest I've updated my pull request with a fix for this issue.
All messaging between apps related to closing mock app windows and checking if mock app execution has been completed is now done over a single dedicated app channel named "app-control"
In addition, the changes I made to the channel tests with regard to using window.close for closing app windows instead of using Finsemble's implementation have been carried over to all other tests.
Also, the timeout that waits for the mock app windows to close has now been removed for all tests -- not just the channel tests.
I'm currently on holiday until Monday so I won't be available until then, but that pull request should resolve all of the most pressing issues.
from fdc3-conformance-framework.
kriswest
commented on August 18, 2024
@Joe-Dunleavy great that does indeed resolve the issue.
However, I've hit a different one it has exposed. There is a race between the execution-complete messages and the listeners being added for them. Have commented on the PR on an example and possible solution.
window.close isn't working for me in BrowserView windows in a current Finsemble release (a regression we're working on) if that does affect you can tell via the central logger (are the invisible mock apps closing?). To workaround that add manifest.foreign.components.Window Manager.titlebarType = "injected" to the config of each mock.
from fdc3-conformance-framework.
Joe-Dunleavy
commented on August 18, 2024
@kriswest I was able to resolve the issue with windows not closing when using window.close when you mentioned the workaround in a previous comment.
Do you still want me to look into the issue regarding the "race between the execution-complete messages and the listeners being added for them" or has that since been resolved?
from fdc3-conformance-framework.
kriswest
commented on August 18, 2024
Take a look at the open PR and add a review if you would - its recreating
your PR + my changes. The race seems solved for me - I had to make the
handling of the execution messages dependent on the test name to resolve
(so it can ignore one from a previous test if it needs to).
#85
…On Mon, 31 Oct 2022 at 09:57, Joe Dunleavy ***@***.***> wrote:
@kriswest <https://github.com/kriswest> I was able to resolve the issue
with windows not closing when using window.close when you mentioned the
workaround in a previous comment.
Do you still want me to look into the issue regarding the "race between
the execution-complete messages and the listeners being added for them" or
has that since been resolved?
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM7PBBJRJXZ4GPU24QDTKTWF6JZDANCNFSM6AAAAAARNHZAVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Kris West
Principal Engineer
[image: Finsemble] <https://cosaic.io/finsemble>
+1 (800) 821-8147
***@***.***
from fdc3-conformance-framework.
Related Issues (20)
- Manual Intent Resolver Check HOT 2
- Use TestContextZ with RaiseIntent2 HOT 1
- FindInstances Test to use App A HOT 1
- CloseMockAppWindow using wrong id HOT 1
- Add Awaits into src/mock/channel-commands HOT 1
- user-channels.ts HOT 1
- Merge Release Candidate into Main Branch HOT 2
- Remove Sleep from RaiseIntentFailTargetedAppResolve3 and RaiseIntentFailTargetedAppResolve4 HOT 1
- "Debugger". in fdc3.app-channels.ts
- UCBasicUsage3 = not set up in correct order HOT 1
- RaiseINtentFialTargetedAppInstanceResolve2
- RaiseIntentContextResult61Secs HOT 1
- 2.0 Get Info2
- Do code review and make sure all unsubscribe listeners happen HOT 1
- Got an error "No Context received" for the test 2-0RaiseIntentContextResult61Secs when run on the latest Glue Core code
- Investigate Cucumber
- Indicate that tests are finished (to make use in a CI system easier) HOT 1
- Basic tests can be flaky in a CI system
- Conformance tests don't test retrieving User channels like app channels
- Conformance Framework not available from FINOS App Directory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fdc3-conformance-framework.