Code Monkey home page Code Monkey logo

Comments (3)

finalduty avatar finalduty commented on September 7, 2024

Hey @kleinbottle,

Thank you for your feedback and for raising this issue. Good spotting 🙂

The audit_duplicate_group_names function is already defined, but it looks that I must've copy/pasted this config from 6.2.5 but forgot to update the test it calls.

cis-benchmarks-audit/cis_audit.py

Lines 404 to 412 in b903fe7

def audit_duplicate_group_names(self) -> int:
state = 0
cmd = R'cut -d: -f1 /etc/group | sort | uniq -d'
r = self._shellexec(cmd)
if r.stdout[0] != '':
state = 1
return state

The fix for this would be as to update the test that gets referenced by 6.2.6 on Line 2583.

cis-benchmarks-audit/cis_audit.py

Line 2538 in b903fe7

{'_id': "6.2.6", 'description': "Ensure no duplicate user names exist", 'function': CISAudit.audit_duplicate_user_names, 'levels': {'server': 1, 'workstation': 1}},

If you would like to show up as a code contributor on the repo, I will happily review a Pull Request to fix this. I don't have any contribution guidelines as of yet though I'm afraid. If you don't want to do make the change yourself though, I'll happily update this on your behalf.

In any case, thank you again for taking the time to raise the issue, it's greatly appreciated 😊

from cis-benchmarks-audit.

nandac avatar nandac commented on September 7, 2024

@finalduty Thanks for your prompt reply. I accidentally logged into the wrong user for raising this issue. I will look into creating a pull request for this feature.

Cheers

from cis-benchmarks-audit.

nandac avatar nandac commented on September 7, 2024

@finalduty I have submitted a pull-request here: #43 and have tested it out on my project and it works for me.

Unfortunately, I cannot give you the test results because of licensing issues on my end.

from cis-benchmarks-audit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.