Fix handling of errors when encoding exceptions with scodec about finagle-serial HOT 3 CLOSED

Just to clarify: this is only a problem if an error happens while encoding CodecError or ApplicationError.

from finagle-serial.

Looking back at this after a few weeks, I think I'm fine with the current behavior, and at least in the case of CodecError it's the most straightforward approach to avoiding a loop where you fail while encoding a CodecError, and then while encoding the CodecError that represents that failure, and so on.

As I mention above, failure encoding one of these two error types should be extremely rare (like the case of an Scodec error message being more than 65,536 characters long), so it doesn't seem unreasonable to use ServerApplicationError as a "we give up, something really bad happened" error.

Mind if I close this, @vkostyukov?

from finagle-serial.

Totally agree! Please go ahead with closing it.

from finagle-serial.