Code Monkey home page Code Monkey logo

Comments (6)

AlapanSen avatar AlapanSen commented on May 27, 2024 2

Adding bitrate information directly in the details tab of the Files app sounds like a useful enhancement, especially for users who frequently work with audio files and need quick access to such information. It streamlines the process and eliminates the need to navigate through additional menus to find the desired details.

from files.

0x5bfa avatar 0x5bfa commented on May 27, 2024 1

@Artoryn sure.

from files.

yaira2 avatar yaira2 commented on May 27, 2024 1

Howdy! Would I be able to take this item? It might be a good first contribution or a way for me to get started helping with this project.

Just to pointer to lead you in the right direction, there is a properties json file that lists all the properties to be displayed in the details pane.

from files.

0x5bfa avatar 0x5bfa commented on May 27, 2024

Thank you for the feedback.

For the record, the information can be viewed in the details tab, the Files properties window.

from files.

Artoryn avatar Artoryn commented on May 27, 2024

Howdy! Would I be able to take this item? It might be a good first contribution or a way for me to get started helping with this project.

from files.

Artoryn avatar Artoryn commented on May 27, 2024

While making changes for this, I noticed that there is already code for formatting these bitrates. I believe the formatting should be moved to utilize the DisplayFunctions for both the Preview Pane and the Details section (of the properties window) for Video.EncodingBitrate and Audio.Bitrate.

I wanted to verify whether this would be acceptable due to the "Did you implement any design changes to an existing feature?" as centralizing and using DisplayFunctions would modify the properties window, which is outside the needed changes. Technically, this change is not required, but it cleans duplicate code.

I did notice also that the issue/feature states that the value displayed is "off" as stated "For example a 320kbps audio file on file explorer is shown as 312.5 kbps on files app, and a 192kbps file is shown as 187.5 on files app". From looking, that is most likely due to the calculation being done. 192000 / 1024 would be 187.5 and not 192. So, we could change this conversion to kilo-bits (kbps) instead of kilo-bytes (KBps).

from files.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.